-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ser-de against Java #92
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 98.93% 98.73% -0.20%
==========================================
Files 13 13
Lines 936 951 +15
Branches 131 132 +1
==========================================
+ Hits 926 939 +13
- Misses 5 7 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is in draft, but I'm leaving some observational comments, that mostly does not require addressing I think. The only major thing is the binary file that I think we need to discuss. Otherwise: very cool that this is working and passing tests in CI 👌
The check-manifest pre-commit hook that's failing is a check that makes sure that MANIFEST.in
exhaustively covers all files in the repository, so that we don't accidentally ship things in the PyPI package. Adding a recursive-exclude java_tester *
line is most likely the right thing to do.
44cac61
to
1f3a164
Compare
8d43b54
to
50ea9c0
Compare
29d2e65
to
1008c3f
Compare
This commit introduces special kind of tests that check serialization-deserialization against a Java process, which uses the official Kafka library.
1008c3f
to
5a10cea
Compare
92908db
to
9fac839
Compare
Thanks for this, I think it's a big step in terms of soundness of this library 👌 |
No description provided.