Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ser-de against Java #92

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Test ser-de against Java #92

merged 4 commits into from
Nov 14, 2023

Conversation

ivanyu
Copy link
Contributor

@ivanyu ivanyu commented Oct 15, 2023

No description provided.

@ivanyu ivanyu changed the title Ivanyu/java testing Test with Java Oct 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ceb71d) 98.93% compared to head (9fac839) 98.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   98.93%   98.73%   -0.20%     
==========================================
  Files          13       13              
  Lines         936      951      +15     
  Branches      131      132       +1     
==========================================
+ Hits          926      939      +13     
- Misses          5        7       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aiven-anton aiven-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is in draft, but I'm leaving some observational comments, that mostly does not require addressing I think. The only major thing is the binary file that I think we need to discuss. Otherwise: very cool that this is working and passing tests in CI 👌

The check-manifest pre-commit hook that's failing is a check that makes sure that MANIFEST.in exhaustively covers all files in the repository, so that we don't accidentally ship things in the PyPI package. Adding a recursive-exclude java_tester * line is most likely the right thing to do.

codegen/generate_schema.py Outdated Show resolved Hide resolved
codegen/generate_tests.py Outdated Show resolved Hide resolved
codegen/generate_tests.py Show resolved Hide resolved
src/kio/serial/readers.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
java_tester/gradle/wrapper/gradle-wrapper.jar Outdated Show resolved Hide resolved
@ivanyu ivanyu force-pushed the ivanyu/java-testing branch 5 times, most recently from 8d43b54 to 50ea9c0 Compare October 21, 2023 13:13
@ivanyu ivanyu changed the title Test with Java Test ser-de against Java Oct 21, 2023
@ivanyu ivanyu force-pushed the ivanyu/java-testing branch 4 times, most recently from 29d2e65 to 1008c3f Compare October 21, 2023 13:51
This commit introduces special kind of tests that check serialization-deserialization against a Java process, which uses the official Kafka library.
@ivanyu ivanyu marked this pull request as ready for review November 10, 2023 15:20
@aiven-anton aiven-anton merged commit 579d5a0 into main Nov 14, 2023
6 checks passed
@aiven-anton aiven-anton deleted the ivanyu/java-testing branch November 14, 2023 18:24
@aiven-anton
Copy link
Collaborator

Thanks for this, I think it's a big step in terms of soundness of this library 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants