Skip to content

Commit

Permalink
Rename resourceNameId to resourceOwnerTeamId in ApprovalService.java (#…
Browse files Browse the repository at this point in the history
…2391)

* refactor: Rename resourceNameId to resourceOwnerTeamId to clarify meaning.

Signed-off-by: huGgW <whjoon0225@naver.com>

* fix: Break a line to correct a linting error.

Signed-off-by: huGgW <whjoon0225@naver.com>

---------

Signed-off-by: huGgW <whjoon0225@naver.com>
Co-authored-by: Aindriú Lavelle <121855584+aindriu-aiven@users.noreply.github.com>
  • Loading branch information
huGgW and aindriu-aiven authored Apr 8, 2024
1 parent 3256a35 commit 01de206
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions core/src/main/java/io/aiven/klaw/service/ApprovalService.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,16 @@ public List<Approval> getApprovalsForRequest(
RequestEntityType entityType,
RequestOperationType operationType,
String envName,
Integer resourceNameId,
Integer resourceOwnerTeamId,
Integer aclOwnerId,
int tenantId)
throws KlawException {
List<Approval> approvals = getApprovers(entityType, operationType, envName);
for (Approval app : approvals) {
if (app.getApprovalType() == ApprovalType.TOPIC_TEAM_OWNER
|| app.getApprovalType() == ApprovalType.CONNECTOR_TEAM_OWNER) {
app.setRequiredApprover(manageDatabase.getTeamNameFromTeamId(tenantId, resourceNameId));
app.setRequiredApprover(
manageDatabase.getTeamNameFromTeamId(tenantId, resourceOwnerTeamId));
} else if (app.getApprovalType() == ApprovalType.ACL_TEAM_OWNER) {
app.setRequiredApprover(manageDatabase.getTeamNameFromTeamId(tenantId, aclOwnerId));
}
Expand Down

0 comments on commit 01de206

Please sign in to comment.