fix(coral): Update handling for open CLAIM request in promotion. #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
programmiri
force-pushed
the
1643-link-change-topic-has-open-claim-request
branch
from
a006fb8
to
2e8e755
Compare
roope-kar
requested changes
Aug 18, 2023
Comment on lines
29
to
32
| useEffect(() => { | ||
| console.log("hasOpenClaimRequest", hasOpenClaimRequest); | ||
| console.log("hasOpenSchemaRequest", hasOpenSchemaRequest); | ||
| }); |
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
roope-kar
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Updates
PromotionBannerto take propertyhasOpenClaimRequest:/approvals(type CLAIM) and inform user that there is an open claim request/request(type PROMOTE) and inform user that there is an open promotion request/request(type ALL) and inform user that there is a pending requestRecording for topic
promotion-banner-recording.mov
Recording for schema
NOTE: In this recording, a little inconsistency is visible: I (as part of another team) did the claim request for the schema I wanted to show. If I'm the one making the request, I won't see it in
/approvalsbecause I can not approve my own requests (even if they are from another team). We currently don't have a way to avoid that, but it is not a common use case anyway.promotion-banner-recording-schema.mov
Resolves #1643