Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update startup scripts #2026

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Update startup scripts #2026

merged 1 commit into from
Nov 24, 2023

Conversation

muralibasani
Copy link
Contributor

Linked issue

Resolves: #xxxxx

What kind of change does this PR introduce?

  • [ X] Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
Startup scripts in bin dir would not execute properly if ran from a different dir

What is the new behavior?

Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).

setting the working dir properly now

Other information

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

Signed-off-by: muralibasani <muralidahr.basani@aiven.io>
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, There is a note that I want to add which is the logs are generated in the directory you execute the command in but this is in my experience normal behaviour in a lot of applications so I think this is alright

@muralibasani muralibasani merged commit 2cafc28 into main Nov 24, 2023
13 of 14 checks passed
@muralibasani muralibasani deleted the fixscript branch November 24, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants