Add distributionSha256Sum for maven #2030
Conversation
Signed-off-by: Sergey Nuyanzin <snuyanzin@gmail.com>
There was a problem hiding this comment.
I ran this on windows and Linux, the windows version kept on failing on the cluster-api.
[ERROR] Failures:
[ERROR] ClusterApiControllerIT.getTopicContents:780
expected: 2
but was: 0
[INFO]
[ERROR] Tests run: 26, Failures: 1, Errors: 0, Skipped: 0
Also the links to the apache license were switched to http from https
| @@ -7,7 +7,7 @@ | |||
| @REM "License"); you may not use this file except in compliance | |||
| @REM with the License. You may obtain a copy of the License at | |||
| @REM | |||
| @REM https://www.apache.org/licenses/LICENSE-2.0 | |||
| @REM http://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
did you mean to switch this back to http?
There was a problem hiding this comment.
this is the result of mvn wrapper:wrapper code generation
so i guess it's better to keep it as is and probably to fix it first in upstream project
| @@ -8,7 +8,7 @@ | |||
| # "License"); you may not use this file except in compliance | |||
| # with the License. You may obtain a copy of the License at | |||
| # | |||
| # https://www.apache.org/licenses/LICENSE-2.0 | |||
| # http://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
Did you mean to switch this back to http?
There was a problem hiding this comment.
this is the result of mvn wrapper:wrapper code generation
so i guess it's better to keep it as is and probably to fix it first in upstream project
There was a problem hiding this comment.
Cool I am happy with that. I will do some digging on the issue with the failing test on windows, as it only happens on this branch. (5/5 times) didnt happen when I ran it on main. I'll let you know if it can be fixed or what the RCA is
|
I reviewed the failing test it was only added on Friday and passes on Linux/Mac so I dont believe this change has any impact on it. I am going to approve this and will look at rewriting the test to be windows compatible. |
|
thanks for taking a look |
There is now support for checksum checks while downloading maven
this support is added here
also there is suppport for similar check for wrapper however it doen not work well for Windows as mentioned at
MVRAPPER-103.
Now it is commented till the issue is fixed
most of the changes are result of generated code via command
./mvnw wrapper:wrapper