Update to make activity log descending order by default and allow the api to accept the order preferred #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… api to accept the order prefered Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
muralibasani
reviewed
Mar 6, 2024
| import io.aiven.klaw.model.enums.RequestMode; | ||
| import io.aiven.klaw.model.enums.RequestOperationType; | ||
| import io.aiven.klaw.model.enums.RequestStatus; | ||
| import io.aiven.klaw.model.enums.*; |
There was a problem hiding this comment.
If you want to double check this wild card import
There was a problem hiding this comment.
Thanks my intellij settings for this got reset 👎 have put them back to normal now and will push up these updates in a sec
muralibasani
reviewed
Mar 6, 2024
| import io.aiven.klaw.model.enums.RequestMode; | ||
| import io.aiven.klaw.model.enums.RequestOperationType; | ||
| import io.aiven.klaw.model.enums.RequestStatus; | ||
| import io.aiven.klaw.model.enums.*; |
There was a problem hiding this comment.
Also here on the wild card import
muralibasani
reviewed
Mar 6, 2024
| import io.aiven.klaw.model.enums.RequestMode; | ||
| import io.aiven.klaw.model.enums.RequestOperationType; | ||
| import io.aiven.klaw.model.enums.RequestStatus; | ||
| import io.aiven.klaw.model.enums.*; |
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to make activity log descending order by default and allow the api to accept the order preferred
Linked issue
Resolves: #xxxxx
What kind of change does this PR introduce?
What is the current behavior?
API returns activity log from oldest to newest
What is the new behavior?
API returns activity log from newest to oldest
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully