refactor(coral): Add failOnConsole for errors and warnings to test setup #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmiri
force-pushed
the
remove-console-errors
branch
from
4d4432d
to
8030d31
Compare
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
programmiri
force-pushed
the
remove-console-errors
branch
from
8030d31
to
5b041e4
Compare
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
programmiri
force-pushed
the
remove-console-errors
branch
from
5b041e4
to
4718019
Compare
mathieu-anderson
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fail-on-consoleis a package I've used in the past & aquarium as well as console are using it, too. IThis PR:
customRenderthe console.error seems to happen async (?) or at leat in a way thatfailOnConsoleis not able to catch it. We can see if we fix that in the future.What kind of change does this PR introduce?