Wait for a recheck after config reload and detection of primary not being available #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdunklau
force-pushed
the
rdunklau/use_that_new_state
branch
from
5ea3daa
to
d856fce
Compare
rdunklau
force-pushed
the
rdunklau/use_that_new_state
branch
from
d856fce
to
9ffc8c6
Compare
alexole
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 67d96f4, which moves the reload of the config in the main thread, we can now take a failover decision right after a config change, without waiting for the newly initiated check to be performed.
Similarly, we need to wait for the check triggered when the primary is unreachable to complete before we make a decision.