Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New implementation] Refactor transform/detransform logic to be on the same component #207

Open
jeqo opened this issue May 8, 2023 · 2 comments

Comments

@jeqo
Copy link
Contributor

jeqo commented May 8, 2023

Transforms and detransforms are on different components (URSM and ChunkManager) atm. These are tightly related and should be on the same component.

Discussion: #206 (review)

@jeqo jeqo changed the title [New implementation [New implementation] Refactor transform/detransform logic to be on the same component May 8, 2023
@ivanyu
Copy link
Contributor

ivanyu commented May 9, 2023

I generally appreciate the motivation behind this, but would like to warn against making the code overly complex to achieve the goal if it comes to this. Let's stay practical :)

@jeqo
Copy link
Contributor Author

jeqo commented May 10, 2023

Sure, no priority for this until we have the RSM implementation merged into the new-implementation branch.
Just keeping track of the discussion on #206, let's revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants