Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add config docs generation #601

Merged
merged 4 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/git.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,17 @@ jobs:
- uses: actions/checkout@v3
- name: Block Fixup Commit Merge
uses: alexkappa/block-fixup-merge-action@v2

- name: Gen docs
run: make docs

- name: Check for uncommitted changes
run: |
if [[ -n $(git status -s) ]]; then
echo "There are uncommitted changes after the task:"
git status -s
exit 1
else
echo "No changes detected."
fi
shell: bash
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ storage/gcs/build/distributions/gcs-$(VERSION).tgz:
storage/azure/build/distributions/azure-$(VERSION).tgz:
./gradlew build :storage:azure:distTar -x test -x integrationTest -x e2e:test

.PHONY: docs
docs:
./gradlew :docs:genConfigDocs

test: build
./gradlew test -x e2e:test

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,9 @@ public void ensureValid(final String name, final Object value) {
throw new ConfigException(name + " value must not be empty");
}
}

@Override
public String toString() {
return "Non-empty password text";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,10 @@ public void ensureValid(final String name, final Object value) {
validator.ensureValid(name, value);
}
}

@Override
public String toString() {
return "null or " + validator.toString();
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,9 @@ public void ensureValid(final String name, final Object value) {
throw new ConfigException(name + " should be a subclass of " + parentClass.getCanonicalName());
}
}


@Override
public String toString() {
return "Any implementation of " + parentClass.getName();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,9 @@ public void ensureValid(final String name, final Object value) {
}
}
}

@Override
public String toString() {
return "Valid URL as defined in rfc2396";
}
}
Loading
Loading