refactor: expose configDef() for all cache config sets #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/refactor-cache-config
branch
from
b1576a8
to
b6d58ca
Compare
This is needed for documentation purposes, while also improving the cache config builder.
jeqo
force-pushed
the
jeqo/refactor-cache-config
branch
from
b6d58ca
to
881af51
Compare
jeqo
commented
Oct 1, 2024
There was a problem hiding this comment.
I'd start review here: this is the main change affecting the cache config hierarchy.
Then continue with MemorySegmentIndexes/MemorySegmentManifest configs, and then ChunkCacheConfig and its children
Comment on lines
+43
to
46
| public CacheConfig( | ||
| final ConfigDef configDef, | ||
| final Object defaultSize, | ||
| final long defaultRetentionMs | ||
| final Map<String, ?> props | ||
| ) { |
There was a problem hiding this comment.
Disentangle configDef from CacheConfig. Instead the DefBuilder defines the config definition.
There was a problem hiding this comment.
Just adjusting new instantiation.
biggusdonzus
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for documentation purposes (#601), while also improving the cache config builder.