feature request: auto retry + skip

[ImSingee]

Describe the feature or enhancement

Now, if cloning of any repo fails, the program exits immediately.

Sometimes, this is a permission problem, and sometimes a temporary network issue or rate limit error.

I hope if there's an error occurs, it should be auto-retry for some time (to prevent temporary error), and if it's still error after the maximum retry time, simply skip it and handle next repo (not exit the whole program).

[AkashRajpurohit]

makes sense, thanks for the sharing the suggestion.

[AkashRajpurohit]

Additionally, if you want to contribute with this feature then feel free to pick it up! :)

[ImSingee]

@AkashRajpurohit Got it. Since the project is new for me, I don’t have enough time to work on it now. But I may take it next week if I have free time then.

[AkashRajpurohit]

@ImSingee this feature have been landed in the latest 0.15.0 release. It was quite fun working on this, thanks for the sharing about this, do try it and let me know if you face any issues.

[ImSingee]

@AkashRajpurohit Thanks for implementing my request feature!

BTW, I belive there must be a problem related the retry:

git-sync/pkg/sync/sync.go

Line 79 in 9ebbaf6

output, err := command.CombinedOutput()

The command is reused between the retry. But it can't -- the second (and later) call to CombinedOutput will fail as Golang expect each command to be only used once and it will return a "stdout is already set" error (https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/os/exec/exec.go;l=1013).

I don't have a computer with golang setup now. I will submit the PR tomorrow (but if you have time, feel free to fix it by yourself).

[AkashRajpurohit]

Nice catch, thanks for pointing this out.
I've pushed this commit to address this, let me know if you have any thoughts on this. Will create a patch release on 0.15 with this fix.

[AkashRajpurohit]

@all-contributors please add @ImSingee for ideas.

[allcontributors]

@AkashRajpurohit

I've put up a pull request to add @ImSingee! 🎉