Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 sync using origin remote by default #55

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jbonadiman
Copy link
Contributor

I believe this change should fix the errors related to tokens being expired or overall changes to the config not being used after the first clone.
Instead of relying explicitly or implicitly in the origin remote, I used the URL that we already combine every time as a parameter to the <repository> argument of the fetch and pull commands.
I tested this with a simple testcase that I created on purpose, if someone could please test this further (preferably with a real issue - the ones regarding the error code 128), that would be awesome.

Fix the issue of updates to the config file not being used for syncs
after the first clone.
Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 70dd245

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AkashRajpurohit
Copy link
Owner

@jbonadiman can you list down the tests that you did as well?

@jbonadiman
Copy link
Contributor Author

@jbonadiman can you list down the tests that you did as well?

I did the token expired test:

  • using the Forgejo client, I cloned a private repository with a token, then I regenerated it and this caused the git client error code 128.
  • using the GitHub client, I followed the same steps and also got the git client error code 128.

Applying the changes in this PR, made it work again.

Copy link
Owner

@AkashRajpurohit AkashRajpurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AkashRajpurohit
Copy link
Owner

AkashRajpurohit commented Oct 11, 2024

This should address and close #53

@AkashRajpurohit AkashRajpurohit linked an issue Oct 11, 2024 that may be closed by this pull request
@AkashRajpurohit AkashRajpurohit merged commit 9fd19cd into AkashRajpurohit:main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git remotes management
2 participants