Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings problem in version 0.4 #9

Open
tonycpsu opened this issue Jun 8, 2015 · 12 comments
Open

Settings problem in version 0.4 #9

tonycpsu opened this issue Jun 8, 2015 · 12 comments
Assignees
Labels

Comments

@tonycpsu
Copy link

tonycpsu commented Jun 8, 2015

On Firefox 38.0.5, OS X 10.10.3, I'm having a problem where my settings aren't appearing in the settings dialog, and I can't seem to add any new ones. The settings from the previous version still seem to be in effect -- if I load URLs that match my old rules, they do open in the proper tabs -- but I can't change the settings or even see them in the dialog.

@Akimkin
Copy link
Owner

Akimkin commented Jun 8, 2015

Can you, please, provide me the output from browser console?
The steps for obtaining output are following:

  1. Close all tabs except addon manager.
  2. Call browser console (Cmd + Shift + J) and press Clear button if there's already any output there.
  3. Open the settings dialog and try to add new setting.

Unfortunately, it will take some time (several days) for me to get a Mac here. In a meantime you can downgrade to 0.3.1-signed version which is available here: https://addons.mozilla.org/en-US/firefox/addon/autogroup/versions/

@Akimkin Akimkin added the bug label Jun 8, 2015
@Akimkin Akimkin self-assigned this Jun 8, 2015
@tonycpsu
Copy link
Author

tonycpsu commented Jun 8, 2015

Nothing interesting in the console, just one message starting with: "OpenGL compositor Initialized Succesfully..."

Downgrading to 0.3.1 lets me see/edit my settings again. Will use that for now.

@Akimkin Akimkin modified the milestones: autogroup-0.4, autogroup-0.4.1 Jun 9, 2015
@gavia
Copy link

gavia commented Jul 2, 2015

I'm having the same issue (and solution) as @tonycpsu. Same specs (Firefox 38.0.5, OS X 10.10.3). I've turned off automatic updates for now.

@tonycpsu
Copy link
Author

Any chance of a fix for this?

@Akimkin
Copy link
Owner

Akimkin commented Sep 21, 2015

I haven't forgotten about this bug. It just appeared to be quite a problem to get an access to some OSX device in this area. Finally found one, gonna get to it in about few weeks.

@tonycpsu
Copy link
Author

Very cool!

@stek29
Copy link

stek29 commented Jan 31, 2016

Is it fixed?

@Akimkin
Copy link
Owner

Akimkin commented Jan 31, 2016

Unfortunately not. Failed to reach Mac that time, waiting for a chance to find another one.

@stek29
Copy link

stek29 commented Jan 31, 2016

Maybe I could help?
I couldn't give you my mac :), but we have internet!

@Akimkin
Copy link
Owner

Akimkin commented Jan 31, 2016

Of course!
I actually asked some guys living far away from my place to give me screenshots, but the main problem with this issue is that there ain't no errors in browser's console, so I even can't definitely tell what's wrong. That's why I'm seeking for a Mac for so long: I'll probably need to spend several hours with OSX trying various changes to code in order to see what's wrong or, at least, to get some helpful debug output.

And, because I don't know for sure, here go my assumptions on this issue.

The problem began after some heavy refactoring in config UI and settings handling. These changes were introduced via following commits:
autogroup-0.3.1...autogroup-0.4

I assume (but I may be wrong), that the root problem is related to XUL UI operation, probably some threading/synchronization stuff, which could be handled differently by OSX, but is fine (or not fine, but "mostly works") for Windows and GNU/Linux. Actually, UI code was quite dirty from the beginning and one of the scopes for the above changeset was to clean it a bit (in order to make adding new features easier). Не фартануло :(

I think, first step to debug this is to determine the commit where things went wrong. If my assumptions above are correct or close, it should probably be d7bff7b. But, unfortunately, I'm not sure whether the addon will work with preceding commits, I didn't do build for each commit.

So, as for the fix, I think, I'll need some examples on correct usage of XUL UI to understand my mistake. And, I could make test builds to anyone wishing to participate in testing fix.

@Akimkin
Copy link
Owner

Akimkin commented Feb 23, 2016

Okay, it seems I found the fix.
Looks like the problem is in the script at the bottom of options.xul file which is responsible for initialization of JS code for preferences UI. For some reason "load" event does not fire on Mac for a prefpane, but works for window. So, if instead:
window.document.getElementById('autogroup-pane-groups').addEventListener("load", ...
use following:
window.addEventListener("load", ...
(like it was for Autogroup v0.3.x) that makes UI work on Mac.

I'll need a bit more additional testing, but that seems the case. I'll commit the fix soon.

@Akimkin
Copy link
Owner

Akimkin commented Feb 24, 2016

So, the fix is in master (tag autogroup-0.4.1). Electrolysis support branch (dev-e10s) is also updated to these changes.
Test, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants