Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMK Update #2

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Conversation

AlexanderSehr
Copy link
Owner

@AlexanderSehr AlexanderSehr commented Nov 2, 2024

Description

Update CMK implementations as per Azure#2842 (comment)
Docs Update: Azure/Azure-Verified-Modules#1683
UDT update: Azure#3724

Removed CMK from AKS module as only enabled via DiskEncryptionSet

Pipeline Reference

Pipeline Ported
avm.res.app-configuration.configuration-store Azure#3729
avm.res.automation.automation-account Azure#3730
avm.res.batch.batch-account Azure#3731
avm.res.cognitive-services.account Azure#3732
avm.res.container-instance.container-group Azure#3733
avm.res.container-registry.registry Azure#3734
avm.res.container-service.managed-cluster
avm.res.data-factory.factory Azure#3735
avm.res.databricks.workspace Azure#3736
avm.res.db-for-my-sql.flexible-server Azure#3737
avm.res.db-for-postgre-sql.flexible-server Azure#3739
avm.res.event-hub.namespace Azure#3759
avm.res.kusto.cluster Azure#3766
avm.res.load-test-service.load-test Azure#3760
avm.res.machine-learning-services.workspace Azure#3765
avm.res.net-app.net-app-account
avm.res.service-bus.namespace
avm.res.storage.storage-account
avm.res.synapse.workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Nov 4, 2024
AlexanderSehr added a commit to Azure/bicep-registry-modules that referenced this pull request Nov 5, 2024
…to-rotation (#3724)

## Description

- Added additional variant of CMK UDT for resources supporting
auto-rotation
- Testing in
AlexanderSehr#2

Docs update: Azure/Azure-Verified-Modules#1683

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.utl.types.avm-common-types](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.utl.types.avm-common-types.yml/badge.svg?branch=users%2Falsehr%2FcmkUDTVariant&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.utl.types.avm-common-types.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
@AlexanderSehr AlexanderSehr changed the title feat: CMK Update (fetch latest) feat: CMK Update Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant