Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the discriminative metric in tsgm following
evaluation.ipynb
. I found in most cases, the results would be very close to 0.5. Besides, there would be a warning about usingsoftmax
in one class classification and the training loss was abnormal.I have checked the source codes of classification models in the zoo, and I find that all models utilize
softmax
activation before the output layer.When setting the output_dim to 1 following
evaluation.ipynb
for classification models, the output would be all ones, in which the classification model would not work.If directly set output_dim to 2, there would be a size error for metric calculation. I think this is due to the implementation of
DiscriminativeMetric
:This version is suitable for binary classification with
sigmoid
activation. Therefore, I recommend modifying it so that it also works withsoftmax
.Besides, the definition of the classification model should be changed as follows: