Add all the changes back #11
Conversation
There was a problem hiding this comment.
Status: Approved 🎉 ✔️
Hi @team,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Implemented required changes. ✔️
- No linter errors. ✔️
- Good README file. ✔️
- Correct Gitflow. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <div class="general-container"> | ||
| <h2>Sign up</h2> | ||
|
|
||
| <%= form_for(resource, as: resource_name, url: registration_path(resource_name)) do |f| %> | ||
| <%= render "devise/shared/error_messages", resource: resource %> | ||
|
|
||
| <div class="field"> | ||
| <%= f.label :name %><br /> | ||
| <%= f.text_field :name, autofocus: true %> | ||
| </div> | ||
|
|
||
| <div class="field"> | ||
| <%= f.label :email %><br /> | ||
| <%= f.email_field :email, autofocus: true, autocomplete: "email" %> | ||
| </div> | ||
|
|
||
| <div class="field"> | ||
| <%= f.label :password %> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= @minimum_password_length %> characters minimum)</em> | ||
| <% end %><br /> | ||
| <%= f.password_field :password, autocomplete: "new-password" %> | ||
| </div> | ||
|
|
||
| <div class="field"> | ||
| <%= f.label :password_confirmation %><br /> | ||
| <%= f.password_field :password_confirmation, autocomplete: "new-password" %> | ||
| </div> | ||
|
|
||
| <div class="actions"> | ||
| <%= f.submit "Sign up" %> | ||
| </div> | ||
| <% end %> | ||
|
|
||
| <%= render "devise/shared/links" %> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
- [OPTIONAL] You may consider impelement the suggestion from the previous reviewer by adding an input to get information about bio of the user, to make sure match the wireframes from the Sneak Peek
The first review: #9
Applied all the changes.