Feature forms #7
Conversation
There was a problem hiding this comment.
Hi @Alibaba2023,
Great job so far! 👏
You've done well, however, there are some issues that you still need to work on to go to the next project, but you are almost there!
To highlight 🎯
- Nice effort trying to add the forms ✔️
- Nice design. ✔️
- Descriptive PR. ✔️
Required Changes ♻️
Check the comments below.
- After creating some users and adding some posts, they seem not to be showing up on the webpage. All the routes are empty, showing blank pages. Please, kindly fix this so your project can be reviewed properly.
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hi @zieeco |
There was a problem hiding this comment.
Hi @Alibaba2023,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
- Correct workflow was used ✔️
- Well-organized and clean project ✔️
- No linter error ✔️
- Professional readme file ✔️
Status: Approved ✔️✔️✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100%.
Please, remember to tag me @uwadonat in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Changes: