Feature integration specs for views n+1 #8
Conversation
There was a problem hiding this comment.
Hi @Alibaba2023 👋🏼👋🏼👋🏼,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights✅✅✅
- All written tests are passing👍🏼.
- A majority of the test cases has been captured👍🏼.
- Capybara gen is present in the gemfile👍🏼.
Required Changes ♻️
- Kindly adjust the naming convention for your test files
post_index_spec.rb,post_show_spec.rb,user_index_spec.rbNOTpost_index.spec.rbetc. as you have used. The test files not properly named will be ignored when you run the test😉.
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
spec/features/posts_index.spec.rb
Outdated
| it 'shows the number of comments and likes' do | ||
| visit user_posts_path(users(:one)) | ||
|
|
||
| expect(page).to have_text("Comments: #{posts(:one).comments.count}") | ||
| expect(page).to have_text("Likes: #{posts(:one).likes.count}") | ||
| end |
There was a problem hiding this comment.
Nice job so far as your project has captured almost all the test cases😉. but just as required, kindly add a test that asserts you can see the first comment on a post😉.
There was a problem hiding this comment.
Thank you for the feedback.
…Alibaba2023/blog_app into feature_integration_specs_for_views_n+1
There was a problem hiding this comment.
STATUS: APPROVED 🟢
Hi @Alibaba2023 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
(Highlights) Good Points: 👍
- You documented your work professionally. ✔
- You used GitHub flow correctly. ✔
- Well done adding the remaining test. 🎉 🎉 🎉 ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Changes in this PR:
Team members: @Alibaba2023 and @hajnaloltyan