Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL Analysis: consteval compile_time_hash #12821

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

aalkin
Copy link
Member

@aalkin aalkin commented Mar 6, 2024

  • Make consteval compile_time_hash
  • Use constexpr version named runtime_hash in the dynamic contexts where compile_time_hash cannot be used

@aalkin aalkin requested a review from a team as a code owner March 6, 2024 13:14
Copy link
Contributor

github-actions bot commented Mar 6, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@alibuild
Copy link
Collaborator

alibuild commented Mar 7, 2024

Error while checking build/O2/fullCI for 37c377d at 2024-03-07 03:33:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command o2-sim --seed 12345 -j 32 -n 100 -m PIPE ITS MFT FT0 FV0 FDD -g extgen -e TGeant4 --configKeyValues "GeneratorExternal.fileName=$O2_ROOT/share/Generators/external/QEDLoader.C;QEDGenParam.yMin=-7;QEDGenParam.yMax=7;QEDGenParam.ptMin=0.001;QEDGenParam.ptMax=1.;${SIMOPTKEY}" --run 310000 had nonzero exit code 134
[FATAL] Empty, missing or invalid response from query to RCT/Info/RunInformation for run 310000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/f303e8e25c10a5b443498d16853d49038b6ba1b9/slc8_x86-64/o2checkcode/1.0-local1403/etc/modulefiles
++ cat
--

Full log here.

@ktf
Copy link
Member

ktf commented Mar 7, 2024

Crash unrelated. Tested on hyperloop. Merging.

@ktf ktf merged commit 720db9f into AliceO2Group:dev Mar 7, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants