Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITSMFT DeadMapBuilder ccdb upload when EoS not processed #12828

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

nicolovalle
Copy link
Contributor

@nicolovalle nicolovalle commented Mar 7, 2024

Fix in the second commit.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@nicolovalle nicolovalle requested a review from a team as a code owner March 8, 2024 21:29
@nicolovalle nicolovalle changed the title [WIP] ITSMFT DeadMapBuilder severity message reduced ITSMFT DeadMapBuilder ccdb upload when EoS not processed Mar 8, 2024
@nicolovalle
Copy link
Contributor Author

News in this PR:

  • ccdb api is used to push the object to ccdb directly from the workflow if End of Stream is not received. In this case a warning is printed (not an error anymore).
  • the TF sampling now ensures that the first TF of the run is always processed (otherwise the map could stay empty e.g. in data replay).

cc @mcoquet642 @iravasen

@shahor02 Could you please review especially the modification done in the aggregator-workflow.sh ? Here I added the ccdb path as new parameter. The workflow ignores it if the EndOfStream is processed and in that case the upload will be done by the ccdb-populator. Thanks.

Tested locally.

@alibuild
Copy link
Collaborator

alibuild commented Mar 9, 2024

Error while checking build/O2/fullCI for 99593a5 at 2024-03-09 19:49:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/dda486f30397d89bacbf4f37aa2794535daad4bf/slc8_x86-64/o2checkcode/1.0-local195/etc/modulefiles
++ cat
--

Full log here.

@nicolovalle
Copy link
Contributor Author

@shahor02 Thanks for checking. Your corrections are implemented.

@shahor02
Copy link
Collaborator

Thanks, I saw, I am waiting for the fullCI to replay. Could you push some dummy commit to re-trigger it?

@shahor02
Copy link
Collaborator

Hi, no, endOfStream is not called w/o EOS.

@nicolovalle
Copy link
Contributor Author

Hi, no, endOfStream is not called w/o EOS.

Thanks. That's consistent with tests and assumptions.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 690f57f at 2024-03-11 14:33:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/3b6b9dd55135b64f5d96edbd2f5402b1fa5bb14c/slc8_x86-64/o2checkcode/1.0-local205/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 3db163e at 2024-03-12 20:09:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/15c0a28deeebef099599cdd0099d5cc24e8fa6b3/slc8_x86-64/o2checkcode/1.0-local213/etc/modulefiles
++ cat
--

Full log here.

@shahor02 shahor02 merged commit 324e29b into AliceO2Group:dev Mar 12, 2024
11 of 12 checks passed
@nicolovalle nicolovalle deleted the nv-its-dmap-patch branch March 19, 2024 12:22
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…p#12828)

* [WIP] ITSMFT DeadMapBuilder severity message reduced

* ccdb api in the workflow

* leaving option for offline processing

* dummy commit to trigger CI

* ec not nullptr

* Dummy commit to trigger CI

---------

Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…p#12828)

* [WIP] ITSMFT DeadMapBuilder severity message reduced

* ccdb api in the workflow

* leaving option for offline processing

* dummy commit to trigger CI

* ec not nullptr

* Dummy commit to trigger CI

---------

Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…p#12828)

* [WIP] ITSMFT DeadMapBuilder severity message reduced

* ccdb api in the workflow

* leaving option for offline processing

* dummy commit to trigger CI

* ec not nullptr

* Dummy commit to trigger CI

---------

Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants