Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMCAL-795]: Add protection for TRUs when cheking HW address #12839

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

jokonig
Copy link
Collaborator

@jokonig jokonig commented Mar 8, 2024

  • Minor altro errors are observed with the error "CHANNEL_ORDER"
  • The altro index for TRUs does not exist and therefore, the altro index is uninitialized
  • Hence, no check for the altro index has to be done for TRUs
  • TRUs correpond to fec==0 in each branch. The Altro Index check is therefore only performed for fec > 0

- Minor altro errors are observed with the error "CHANNEL_ORDER"
- The altro index for TRUs does not exist and therefore, the altro index is uninitialized
- Hence, no check for the altro index has to be done for TRUs
- TRUs correpond to fec==0 in each branch. The Altro Index check is therefore only performed for fec > 0
@jokonig jokonig requested a review from mfasDa as a code owner March 8, 2024 17:57
Copy link
Contributor

github-actions bot commented Mar 8, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

For the record: We need to exclude the check of the ALTRO index for Fake-ALTRO FECs (TRU) since the ALTRO index is undefined there. Fake-ALTRO FECs are always in FEC ID 0.

@mfasDa mfasDa enabled auto-merge (squash) March 8, 2024 18:14
@mfasDa mfasDa merged commit 9d76626 into AliceO2Group:dev Mar 8, 2024
14 checks passed
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…Group#12839)

- Minor altro errors are observed with the error "CHANNEL_ORDER"
- The altro index for TRUs does not exist and therefore, the altro index is uninitialized
- Hence, no check for the altro index has to be done for TRUs
- TRUs correpond to fec==0 in each branch. The Altro Index check is therefore only performed for fec > 0

Co-authored-by: jokonig <jokonig@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
…Group#12839)

- Minor altro errors are observed with the error "CHANNEL_ORDER"
- The altro index for TRUs does not exist and therefore, the altro index is uninitialized
- Hence, no check for the altro index has to be done for TRUs
- TRUs correpond to fec==0 in each branch. The Altro Index check is therefore only performed for fec > 0

Co-authored-by: jokonig <jokonig@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
…Group#12839)

- Minor altro errors are observed with the error "CHANNEL_ORDER"
- The altro index for TRUs does not exist and therefore, the altro index is uninitialized
- Hence, no check for the altro index has to be done for TRUs
- TRUs correpond to fec==0 in each branch. The Altro Index check is therefore only performed for fec > 0

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants