Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOCAL-100] Porting the beam pipe for run 4 (around FOCAL) #13772

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hahassan7
Copy link
Contributor

I implemented the beam pipe for run4. But only in front of FOCAL and inside it. I haven't implement the one behind it in the compensator magnet and beyond.

@hahassan7 hahassan7 requested review from sawenzel and a team as code owners December 5, 2024 13:17
Copy link
Contributor

github-actions bot commented Dec 5, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

alibuild commented Dec 5, 2024

Error while checking build/O2/fullCI_slc9 for a107308 at 2025-01-23 04:27:

[499/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/ResourcePolicyHelpers.cxx.o
[500/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/WSDriverClient.cxx.o
[501/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/VariantPropertyTreeHelpers.cxx.o
[502/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/G__O2Framework.cxx.o
[503/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_AsyncQueue.cxx.o
[504/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_CheckTypes.cxx.o
[505/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_AlgorithmSpec.cxx.o
[506/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ChannelSpecHelpers.cxx.o
[507/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ComputingResourceHelpers.cxx.o
[508/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/TimesliceIndex.cxx.o
[509/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/TopologyPolicy.cxx.o
[510/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/StepTHn.cxx.o
[511/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/WorkflowSpec.cxx.o
[512/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_BoostOptionsRetriever.cxx.o
[513/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/DPLWebSocket.cxx.o
[514/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_CompletionPolicy.cxx.o
[515/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ConfigurationOptionsRetriever.cxx.o
[516/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/PropertyTreeHelpers.cxx.o
[517/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/DataProcessingDevice.cxx.o
[518/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ComputingQuotaEvaluator.cxx.o
[519/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataDescriptorQueryBuilder.cxx.o
[520/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DeviceStateHelpers.cxx.o
[521/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/TableTreeHelpers.cxx.o
[522/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataRefUtils.cxx.o
[523/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataProcessorSpec.cxx.o
[524/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataProcessingStats.cxx.o
[525/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ControlServiceHelpers.cxx.o
[526/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataProcessingStates.cxx.o
[527/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/DeviceSpecHelpers.cxx.o
[528/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DeviceConfigInfo.cxx.o
[529/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ExternalFairMQDeviceProxy.cxx.o
[530/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataDescriptorMatcher.cxx.o
[531/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/DataOutputDirector.cxx.o
[532/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/WorkflowSerializationHelpers.cxx.o
[533/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_AnalysisDataModel.cxx.o
[534/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ConfigParamRegistry.cxx.o
[535/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_FairMQ.cxx.o
[536/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_ConfigParamStore.cxx.o
[537/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_FairMQResizableBuffer.cxx.o
[538/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_InputSpan.cxx.o
[539/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/HistogramSpec.cxx.o
[540/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DataRelayer.cxx.o
[541/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_LogParsingHelpers.cxx.o
[542/5695] Building CXX object Framework/Core/CMakeFiles/O2lib-Framework.dir/src/WorkflowHelpers.cxx.o
[543/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_HTTPParser.cxx.o
[544/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_DeviceSpecHelpers.cxx.o
[545/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_FairMQOptionsRetriever.cxx.o
[546/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_InputRecord.cxx.o
[547/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_InputRecordWalker.cxx.o
[548/5695] Building CXX object Framework/Core/CMakeFiles/o2-test-framework-core.dir/test/test_StringHelpers.cxx.o

Full log here.

@sawenzel
Copy link
Collaborator

sawenzel commented Dec 6, 2024

Thank's a lot. This is appreciated!

We should probably discuss this further in a dedicated meeting, but I am wondering already if
(a) you could mention a technical documentation where this is coming from
(b) you would be able/interested to provide the complete beam pipe description for Run4
(c) is it feasible to provide the Run4 beampipe in a completely new file? Since we now have geometry lists defined per run, coexisting classes or files might make a lot of sense

@hahassan7
Copy link
Contributor Author

Hi @sawenzel ,

  1. Here are the documents in this cernbox (https://cernbox.cern.ch/s/TXecg1EZcQ4j5dd). We got these documents from Corrado. And we already used them in AliRoot for FOCAL simulation.
  2. The beam pipe in C side is the same between run3 and 4. The only difference is the beam pipe in the central barrel and infront of FOCAL and behind and a little bit behind the Compensator magnet where the valve will be moved from behind FOCAL to behind compensator magnet. All of these has been implemented except:
  • The beam pipe supports, I couldn't find any documentation about them.
  • The valve is still behind FOCAL, I haven't moved it behind the compensator yet.
  1. I was originally planning to do like that, but then I found that large parts of the beam pipe are similar, so the pipe.cxx code would need small changes to implement.

@alibuild
Copy link
Collaborator

alibuild commented Dec 12, 2024

Error while checking build/O2/fullCI for a107308 at 2025-01-01 08:22:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[32432:calib-phos-l1phase]: [07:21:50][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[32432:calib-phos-l1phase]: [07:21:50][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[32432:calib-phos-l1phase]: [07:21:50][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch//PHS/Calib/BadMap/1735716110306/
[32432:calib-phos-l1phase]: [07:21:50][FATAL] Got nullptr from CCDB for path PHS/Calib/BadMap and timestamp 1735716110306
[32432:calib-phos-l1phase]: [07:21:50][ERROR] Exception while running: Fatal error. Rethrowing.
[32432:calib-phos-l1phase]: [07:21:50][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 32432 (calib-phos-l1phase) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/c4aa125acaa102262fb028273e1b716c7109b920/slc8_x86-64/o2checkcode/1.0-local155/etc/modulefiles
++ cat
--

Full log here.

@sawenzel
Copy link
Collaborator

Hi @hahassan7 :

Thanks for these developments. I am wondering whether it would be possible for you to code an entirely new PIPE2.1 class/file that contains the pipe description for ALICE2.1. In principle we now have the mechanism of run-dependent geometry lists as defined here run/o2simdefaultdetectorlist.json (to be then modified). This would have the advantage that we don't need to mix the code for Run3 and Run4 in the same pipe class.... and we would hence need less conditional clauses.

Let me know if you think this could be done. If it slows you down too much, I can also merge the code as is now to unblock further FOCAL R&D developments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants