[OMON-661] Remove division by 0 log message

CMakeLists.txt

@@ -31,7 +31,7 @@ endif()
 
 # Define project
 project(Monitoring
-  VERSION 3.17.3
+  VERSION 3.17.4
   DESCRIPTION "O2 Monitoring library"
   LANGUAGES CXX
 )

src/DerivedMetrics.cxx

@@ -40,12 +40,12 @@
 bool DerivedMetrics::process(Metric& metric, DerivedMetricMode mode)
 {
   const std::map<DerivedMetricMode, std::function<bool(Metric&)>> map = {
     {DerivedMetricMode::INCREMENT, [this](Metric& metric) {
        auto tags = metric.getTags();
        std::string key = metric.getName();
        std::for_each(tags.begin(), tags.end(), [&key](auto const& pair) {
          key += pair.second;
        });
        auto search = mStorage.find(key);
        if (search != mStorage.end()) {
          auto currentValue = metric.getFirstValue().second;
@@ -59,7 +59,7 @@
        mStorage.insert(std::make_pair(key, metric));
        return true;
      }},
     {DerivedMetricMode::RATE, [this](Metric& metric) {
        /// create pseudo unique key
        auto tags = metric.getTags();
        std::string key = metric.getName();
@@ -80,7 +80,7 @@
        int timestampCount = timestampDifference.count();
        // disallow dividing by 0
        if (timestampCount == 0) {
-         throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
+         //throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
        }
 
        auto current = metric.getFirstValue().second;
@@ -90,7 +90,7 @@
        // handle situation when a new run starts
        auto isZero = std::visit(overloaded{
          [](auto arg) { return arg == 0; },
          [](const std::string& arg) { return arg == ""; }
        }, current);
        if (rate < 0 && isZero) {
          rate = 0;
@@ -103,7 +103,7 @@
        metric.addValue(rate, metric.getFirstValue().first + "_rate");
        return true;
     }},
     {DerivedMetricMode::SUPPRESS, [this](Metric& metric) {
        auto tags = metric.getTags();
        std::string key = metric.getName();
        std::for_each(tags.begin(), tags.end(), [&key](auto const& pair) {

test/testDerived.cxx

@@ -171,15 +171,15 @@ bool exceptionCheck(const MonitoringException& e)
   return false;
 }
 
-BOOST_AUTO_TEST_CASE(divisionByZero)
+/*BOOST_AUTO_TEST_CASE(divisionByZero)
 {
   std::string name("test");
   o2::monitoring::DerivedMetrics derivedHandler;
   o2::monitoring::Metric metric(10, name);
 
   derivedHandler.process(metric, DerivedMetricMode::RATE);
   BOOST_CHECK_EXCEPTION(derivedHandler.process(metric, DerivedMetricMode::RATE), MonitoringException, exceptionCheck);
-}
+}*/
 
 BOOST_AUTO_TEST_CASE(derivedIncrementInt)
 {