Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Fix TPC PID and event selection configurations for analysisQC. #1750

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

mfaggin
Copy link
Contributor

@mfaggin mfaggin commented Sep 20, 2024

No description provided.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@mfaggin mfaggin changed the title [AOT] Fix analysisQC for TPC PID. [AOT] Fix TPC PID and event selection configurations for analysisQC. Oct 1, 2024
@mfaggin
Copy link
Contributor Author

mfaggin commented Oct 1, 2024

Fixes in this PR:

  • configuration of TPC PID dependence: from PR #6005 in O2Physics the o2-analysis-pid-tpc workflow produces both tpc-full and tpc-tiny tables, and the workflow o2-analysis-pid-tpc-full is deprecated. This is now removed

  • configuration of event selection dependence workflow: from PR #7223 in O2Physics the configurable isMC was changed from bool to int, but no changes were done accordingly in O2DPG and this configurable was still configured as true or false and this was preventing the correct configuration of the full pipeline. To solve this, I've exploited the feature introduced by @njacazio that exploits metadata in AO2Ds to determine whether it's data or MC

Everything tested and correctly working on file /alice/data/20242024/LHC24aj/552403/apass1/0850/o2_ctf_run00552403_orbit0680060224_tf0007097933_epn300/001/AO2D.root from alien, and using the following commands (files in AnalysisQC_scripts.tar.gz for future reference):

  1. compile O2Physics and O2DPG: aliBuild build O2Physics O2DPG --defaults o2
  2. enter the environment: alienv enter O2Physics/latest-master-o2 O2DPG/latest
  3. setup the environment variables: source toRunAnalysisQC.sh
  4. build the configuration files: bash script1.sh
  5. execute the AnalysisQC: bash script2.sh

Tagging @chiarazampolli @catalinristea @ekryshen for their knowledge.

@mfaggin
Copy link
Contributor Author

mfaggin commented Oct 1, 2024

+async-label async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7, async-2024-pp-cpass0

@github-actions github-actions bot added async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Hi @mfaggin, the following label names could not be recognised: async-2023-pbpb-apass3

Copy link

github-actions bot commented Oct 1, 2024

Hi @mfaggin, the following label names could not be recognised: , , , , ,

Copy link

github-actions bot commented Oct 1, 2024

Hi @mfaggin, the following label names could not be recognised: async-2023-pbpb-apass3

@chiarazampolli chiarazampolli merged commit 8e68f09 into AliceO2Group:master Oct 2, 2024
6 checks passed
@chiarazampolli
Copy link
Collaborator

Thanks!

alcaliva pushed a commit that referenced this pull request Oct 8, 2024
…1750)

* [AOT] Fix analysisQC for TPC PID.

* Fix TPC-full also for other workflows, for consistency.

* Restore wagon name for TPC PID.

* Autodetect ev. sel isMC based on metadata.

---------

Co-authored-by: Mattia Faggin <mfaggin@alipap1.cern.ch>
(cherry picked from commit 8e68f09)
@alcaliva alcaliva removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Oct 8, 2024
alcaliva pushed a commit that referenced this pull request Oct 8, 2024
…1750)

* [AOT] Fix analysisQC for TPC PID.

* Fix TPC-full also for other workflows, for consistency.

* Restore wagon name for TPC PID.

* Autodetect ev. sel isMC based on metadata.

---------

Co-authored-by: Mattia Faggin <mfaggin@alipap1.cern.ch>
(cherry picked from commit 8e68f09)
@alcaliva alcaliva removed async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pp-apass4 Request porting to async-2023-pp-apass4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants