[PWGJE] dijet mass analysis task (new) #9130
Open
+400
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonggukKim0
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa and
mhemmer-cern
as code owners
github-actions
bot
changed the title
nzardosh
reviewed
Dec 29, 2024
PWGJE/Tasks/dijetFinderQA.cxx
Outdated
| auto& candidate_jet_D = jetPtcuts_D[i]; | ||
| auto& candidate_jet_P = jetPtcuts_P[i]; | ||
|
|
||
| Double_t dphi_D = fabs(atan2(candidate_jet_D[1], candidate_jet_D[0]) - atan2(leading_jet_D[1], leading_jet_D[0])); |
There was a problem hiding this comment.
please use the function constrain angle from the recodecay class that does this phi shift
There was a problem hiding this comment.
Thank you for your comment!
I updated it using constrain_angle for the phi shift.
Let me know if you need anything else!
|
thanks for making a PR. Please ping me when you have addressed the above comment and I will approve |
nzardosh
approved these changes
Jan 22, 2025
|
Please check the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.