-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWGCF] Identified BF Quality checks for MC data #9369
Conversation
[PWGCF] Please consider the following formatting changes to AliceO2Group#9369
Error while checking build/O2Physics/o2 for 21e2452 at 2025-01-17 20:05:
Full log here. |
Error while checking build/O2Physics/o2 for 5ce7d8f at 2025-01-17 20:48:
Full log here. |
constexpr int pdgcodeEl = 11; | ||
constexpr int pdgcodePi = 211; | ||
constexpr int pdgcodeKa = 321; | ||
constexpr int pdgcodePr = 2212; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using named constants from TPDGCode.h instead of numbers for the next iteration
@@ -26,6 +26,7 @@ | |||
#include "Common/Core/TrackSelection.h" | |||
#include "Common/Core/TrackSelectionDefaults.h" | |||
#include "PWGCF/Core/AnalysisConfigurableCuts.h" | |||
#include "MathUtils/Utils.h" | |||
#include <TDatabasePDG.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using TDatabasePDG.h
is highly inefficient
Please check https://indico.cern.ch/event/1482467/contributions/6246612/attachments/2973662/5235085/2024-11-25_O2-linter.pdf
and start moving to O2DatabasePDG service
in the next iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, have a look at my comments
Compiler errors need to be fixed
Fixing my comments is not mandatory for this PR approval. They are for next iterations |
Also, |
Thank you, Victor. I have implemented the compiler error fixes and I have made note of your other comments for my next iteration as well. |
[PWGCF] Please consider the following formatting changes to AliceO2Group#9369
Error while checking build/O2Physics/o2 for e6c65be at 2025-01-21 15:26:
Full log here. |
[PWGCF] Please consider the following formatting changes to AliceO2Group#9369
Error while checking build/O2Physics/o2 for d3287b4 at 2025-01-21 17:42:
Full log here. |
No description provided.