ignoring syncQC provenance in send call until BKP implements it

AliceO2Group · Jun 13, 2024 · f95a85d · f95a85d
1 parent 4822426
commit f95a85d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/Framework/include/QualityControl/BookkeepingQualitySink.h b/Framework/include/QualityControl/BookkeepingQualitySink.h
@@ -48,7 +48,7 @@ class BookkeepingQualitySink : public framework::Task
 
  private:
   std::string mGrpcUri;
-  Provenance mType;
+  Provenance mProvenance;
   SendCallback mSendCallback;
   FlagsMap mQualityObjectsMap;
 

diff --git a/Framework/src/BookkeepingQualitySink.cxx b/Framework/src/BookkeepingQualitySink.cxx
@@ -39,7 +39,7 @@ void BookkeepingQualitySink::customizeInfrastructure(std::vector<framework::Comp
   policies.emplace_back(CompletionPolicyHelpers::consumeWhenAny("BookkeepingQualitySinkCompletionPolicy", matcher));
 }
 
-void BookkeepingQualitySink::send(const std::string& grpcUri, const BookkeepingQualitySink::FlagsMap& flags, Provenance type)
+void BookkeepingQualitySink::send(const std::string& grpcUri, const BookkeepingQualitySink::FlagsMap& flags, Provenance provenance)
 {
   auto bkpClient = o2::bkp::api::BkpClientFactory::create(grpcUri);
   auto& qcClient = bkpClient->qcFlag();
@@ -65,8 +65,9 @@ void BookkeepingQualitySink::send(const std::string& grpcUri, const BookkeepingQ
     }
 
     try {
-      switch (type) {
+      switch (provenance) {
         case Provenance::SyncQC:
+          break;
         case Provenance::AsyncQC:
           qcClient->createForDataPass(flagCollection->getRunNumber(), flagCollection->getPassName(), detector, bkpQcFlags);
           break;
@@ -81,8 +82,8 @@ void BookkeepingQualitySink::send(const std::string& grpcUri, const BookkeepingQ
   }
 }
 
-BookkeepingQualitySink::BookkeepingQualitySink(const std::string& grpcUri, Provenance type, SendCallback sendCallback)
-  : mGrpcUri{ grpcUri }, mType{ type }, mSendCallback{ sendCallback } {}
+BookkeepingQualitySink::BookkeepingQualitySink(const std::string& grpcUri, Provenance provenance, SendCallback sendCallback)
+  : mGrpcUri{ grpcUri }, mProvenance{ provenance }, mSendCallback{ sendCallback } {}
 
 auto merge(std::unique_ptr<QualityControlFlagCollection>&& collection, const std::unique_ptr<QualityObject>& qualityObject) -> std::unique_ptr<QualityControlFlagCollection>
 {
@@ -91,7 +92,7 @@ auto merge(std::unique_ptr<QualityControlFlagCollection>&& collection, const std
   return converter.getResult();
 }
 
-auto collectionFromQualityObject(const QualityObject& qualityObject) -> std::unique_ptr<QualityControlFlagCollection>
+auto collectionForQualityObject(const QualityObject& qualityObject) -> std::unique_ptr<QualityControlFlagCollection>
 {
   return std::make_unique<QualityControlFlagCollection>(
     qualityObject.getName(),
@@ -108,7 +109,7 @@ void BookkeepingQualitySink::run(framework::ProcessingContext& context)
   for (auto const& ref : framework::InputRecordWalker(context.inputs())) {
     try {
       auto qualityObject = framework::DataRefUtils::as<QualityObject>(ref);
-      auto [emplacedIt, _] = mQualityObjectsMap.emplace(qualityObject->getDetectorName(), collectionFromQualityObject(*qualityObject));
+      auto [emplacedIt, _] = mQualityObjectsMap.emplace(qualityObject->getDetectorName(), collectionForQualityObject(*qualityObject));
       emplacedIt->second = merge(std::move(emplacedIt->second), qualityObject);
     } catch (...) {
       ILOG(Warning, Support) << "Unexpected message received, QualityObject expected" << ENDM;
@@ -128,7 +129,7 @@ void BookkeepingQualitySink::stop()
 
 void BookkeepingQualitySink::sendAndClear()
 {
-  mSendCallback(mGrpcUri, mQualityObjectsMap, mType);
+  mSendCallback(mGrpcUri, mQualityObjectsMap, mProvenance);
   mQualityObjectsMap.clear();
 }