[EMCAL-529] Change NumPatchesPerFastORCheck to nsigma over mean checker #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine if a FastOR is noisy by how many sigma it is over the mean FastOR noise level Remove from the list of noisy FastORs any neighboring FastORs to the noisiest ones
sweyh99
requested review from
mfasDa,
jokonig,
Barthelemy and
knopers8
as code owners
|
@mfasDa this seems waiting for your review |
mfasDa
requested changes
Jul 4, 2024
Comment on lines
+171
to
+173
| // Save the final bad FastORs | ||
| FastORNoiseLevel final{ i->mCounts, i->mFastORID, i->mPosGlobalPhi, i->mPosGlobalEta, i->mRejected }; | ||
| finalBadFastORs.push_back(final); |
There was a problem hiding this comment.
final is a reserved keyword, please replace.
mfasDa
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine if a FastOR is noisy by how many sigma it is over the mean FastOR noise level
Remove from the list of noisy FastORs any neighboring FastORs to the noisiest ones