Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2-5072 TrendingTask reuses TTree across runs #2346

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

knopers8
Copy link
Collaborator

No description provided.

knopers8 added 2 commits June 18, 2024 08:57
In some cases we saw TrendingTask crash due to double deletion in a TTree when restarting a run. The stack trace was:
```
TNamed::~TNamed()
TLeafD::~TLeafD()
TObjArray::Delete(char const*)
TBranch::~TBranch()
TObjArray::Delete(char const*)
TTree::~TTree()
TTree::~TTree()
```
Since I was not able to find the root cause and the crash is not consistent, the best I can propose is to avoid deleting the TTree during restart.
Instead, we reuse the tree throughout the lifetime of the task.
technically, it does not change much, just that the plots are deleted at task destruction.
Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Barthelemy Barthelemy merged commit 90231b9 into AliceO2Group:master Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants