Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [QC-1165] CTP review, don't merge #2347

Closed
wants to merge 1 commit into from
Closed

[WIP] [QC-1165] CTP review, don't merge #2347

wants to merge 1 commit into from

Conversation

Barthelemy
Copy link
Collaborator

No description provided.

@Barthelemy Barthelemy changed the title [WIP] CTP review, don't merge [WIP] [QC-1165] CTP review, don't merge Jun 18, 2024
@Barthelemy
Copy link
Collaborator Author

@lhusova @lietava @aferrero2707
I have reviewed the CTP code.

General comments

  • Read apply the O2 coding guidelines: https://github.com/AliceO2Group/CodingGuidelines/
  • I commented a few instances of each issue, please apply the fixes everywhere.
  • Logging: too much, severity and level must be tuned, never use cout
  • I can't really judge the logic because I have no knowledge of the CTP and there is little context provided. Please consider adding more explanation and context in your code.

Specific: see the comments I have put directly in the code

Please, don't merge this branch. Use it as a base or a reference for your changes.

@Barthelemy Barthelemy closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Barthelemy