CTP: changes requested by review #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhusova
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @Barthelemy, dear @knopers8 ,
please have a look on the changes. We didn't touch the CountersTask yet, because it is not used currently and we need to develop the way how to monitor without run, as discussed in the emails, so of this we will create a separate PR later. For the ccdb readout, there was some discussion and it is ongoing, because there were some problems, but we will test also the recommended way. This is what we have now, I wanted to put it here as I'm leaving for holidays next week.
Moreover, this PR contains also a commit changing the TH1F to TH1D, as spotted by Andrea, by integration mode, there are too many entries for TH1F.