ctpdev: removing dependencies on RunManager #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lietava
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
Hi @knopers8 @Barthelemy , please merge or comment. |
|
@lietava We might take a couple of days to review, but we will do it, no worries. |
Barthelemy
approved these changes
Jul 10, 2024
| @@ -18,7 +18,7 @@ | |||
| #include "QualityControl/MonitorObject.h" | |||
| #include "QualityControl/Quality.h" | |||
| #include "QualityControl/QcInfoLogger.h" | |||
| #include "DataFormatsCTP/RunManager.h" | |||
| // #include "DataFormatsCTP/RunManager.h" | |||
There was a problem hiding this comment.
please, remove lines instead of commenting. The history is any ways kept in git.
| metadata["runNumber"] = run; | ||
| auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata); | ||
| if (ctpconfigdb == nullptr) { | ||
| LOG(info) << "CTP config not in database, timestamp:" << mTimestamp; |
There was a problem hiding this comment.
in QC we favour using ILOG i.e. the infologger
| map<string, string> metadata; // can be empty | ||
| metadata["runNumber"] = run; | ||
| auto ctpconfigdb = mgr.getSpecific<o2::ctp::CTPConfiguration>(o2::ctp::CCDBPathCTPConfig, mTimestamp, metadata); | ||
| if (ctpconfigdb == nullptr) { |
There was a problem hiding this comment.
the logic with the ok seems circumvoluted...
|
@Barthelemy thanks for your comments and merge. I will try to implement comments on the next occasion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing dependency on RunManager as discussed in
AliceO2Group/AliceO2#13224
I left old lines commented as it may be moved back after O2 update.