ITS: NCluster plot moved to Double #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @iravasen Could you please approve this request? This is trivial solution to a-QC problem |
iravasen
approved these changes
Jul 10, 2024
iravasen
previously requested changes
Jul 10, 2024
There was a problem hiding this comment.
@IsakovAD thanks, you need also to modify the checkers. Example, this line:
|
No wait sorry you did it! I did not see it. Then I think you can also modify the cluster task. In particular the 1D cluster size distributions. And more in general I think that at this point any TH1F or TH2F which is filled with "counts" need to be moved to TH1D or TH2D |
iravasen
reviewed
Jul 10, 2024
| @@ -453,7 +453,7 @@ void ITSTrackTask::createAllHistos() | |||
| formatAxes(hAngularDistribution.get(), "#eta", "#phi", 1, 1.10); | |||
| hAngularDistribution->SetStats(0); | |||
|
|
|||
| hNClusters = std::make_unique<TH1FRatio>("NClusters", "NClusters", 15, -0.5, 14.5, true); | |||
| hNClusters = std::make_unique<TH1DRatio>("NClusters", "NClusters", 15, -0.5, 14.5, true); | |||
There was a problem hiding this comment.
Modify also the binning as Matteo suggested
|
Hello @iravasen I moved all the plots in Cluster/Track tasks to the Double. FEE task and Decoding error are already fine; |
iravasen
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed type of the nClustersPerTrack histogram from float to double.
This change should fix problem for a-QC where we have overflow of float limits