GLO: Change to TH1Ratio plot

[f3sch]

Changes from TH1 to TH1Ratio to get a correct efficiency after the mergers. One question I have if after each endOfCycle also reset is called?

Tested with:

#!/usr/bin/env sh

GLOSET=" -b --shm-segment-size 4000000000 --hbfutils-config o2_tfidinfo.root,upstream --timeframes-rate-limit 1 --timeframes-rate-limit-ipcid 0 "
CONFIG="$ALIBUILD_WORK_DIR/../QualityControl/Modules/GLO/glo-itstpc-mtch-qcmn-test.json"

export IGNORE_VALIDITYCHECK_OF_CCDB_LOCALCACHE=1
export ALICEO2_CCDB_LOCALCACHE=$PWD/ccdb

o2-reader-driver-workflow --max-tf 2 $GLOSET | \
    o2-global-track-cluster-reader $GLOSET --disable-mc --track-types "ITS,TPC,ITS-TPC,ITS-TPC-TOF,TPC-TOF,TPC-TRD,ITS-TPC-TRD,TPC-TRD-TOF,ITS-TPC-TOF,ITS-TPC-TRD-TOF" --cluster-types "TPC,ITS" --primary-vertices --secondary-vertices | \
    o2-qc --full-chain --config json:///"$CONFIG" --timeframes-rate-limit 1 --timeframes-rate-limit-ipcid 0 -b --run | tee qc.log

Output on qcg-test:

Hopefully everything works now :)

Nota Bene: I added a manual calculation of binomial errors for the efficiency errors (which we might not care about) since TH1Ratio does not support it.

[chiarazampolli]

Hello @f3sch ,

I think that yes, after an endOfCycle, the reset is called, see

QualityControl/Framework/src/TaskRunner.cxx

Lines 362 to 378 in ad246d7

	void TaskRunner::stop()
	{
	try {
	if (mCycleOn) {
	mTask->endOfCycle();
	mCycleNumber++;
	mCycleOn = false;
	}
	endOfActivity();
	mTask->reset();
	} catch (...) {
	// we catch here because we don't know where it will go in DPL's CallbackService
	ILOG(Error, Support) << "Error caught in stop() : "
	<< current_diagnostic(true) << ENDM;
	throw;
	}
	}

, but better that @knopers8 and/or @Barthelemy confirm.

Chiara

[f3sch]

@chiarazampolli super, thanks!

[knopers8]

One question I have if after each endOfCycle also reset is called?

Short answer - yes.
Long answer - it is called when running with Mergers in "delta" mode, which is the only reasonable to use with EPN.

The code that Chiara cited shows TaskRunner::stop(), this happens only at run stop, so it's irrelevant. This is where you can see the reset() after each cycle:

QualityControl/Framework/src/TaskRunner.cxx

Line 201 in befd905

mTask->reset();

[knopers8]

Do you know what happens to the errors when two objects are merged?

[f3sch]

Ah your right, when merged this would be done incorrectly... This should probably be done in the TH1Ratio::update under some flag. Which I guess I can do but do not know if I should?

[knopers8]

I think it's fine, but please do it in a separate PR and I will also ask Andrea to have a look.

[f3sch]

sure, dropped it for now.