Merge pull request #387 from sot528/ALIS-4232

add Class name to exception logs
AlisProject · Sep 9, 2019 · 382c04d · 382c04d
2 parents 6bd4fd7 + 223d3a7
commit 382c04d
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 14 deletions.
diff --git a/src/common/lambda_base.py b/src/common/lambda_base.py
@@ -108,7 +108,7 @@ def main(self):
 
             return {
                 'statusCode': 500,
-                'body': json.dumps({'message': 'Internal server error'})
+                'body': json.dumps({'message': 'Internal server error: ' + self.__class__.__name__})
             }
 
     def __get_params(self):

diff --git a/tests/handlers/login/facebook/authorization_url/test_login_facebook_authorization_url.py b/tests/handlers/login/facebook/authorization_url/test_login_facebook_authorization_url.py
@@ -35,7 +35,7 @@ def test_exec_main_ng_with_clienterror(self):
             self.assertEqual(response['statusCode'], 500)
             self.assertEqual(
                 json.loads(response['body']),
-                {'message': 'Internal server error'}
+                {'message': 'Internal server error: LoginFacebookAuthorizationUrl'}
             )
 
     def test_exec_main_ng_with_fberror(self):
@@ -49,5 +49,5 @@ def test_exec_main_ng_with_fberror(self):
             self.assertEqual(response['statusCode'], 500)
             self.assertEqual(
                 json.loads(response['body']),
-                {'message': 'Internal server error'}
+                {'message': 'Internal server error: LoginFacebookAuthorizationUrl'}
             )
diff --git a/tests/handlers/login/facebook/index/test_login_facebook_index.py b/tests/handlers/login/facebook/index/test_login_facebook_index.py
@@ -332,7 +332,7 @@ def test_main_ng_with_awsexception_and_existing_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginFacebookIndex'
                 }
             )
 
@@ -372,6 +372,6 @@ def test_main_ng_with_awsexception_and_new_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginFacebookIndex'
                 }
             )
diff --git a/tests/handlers/login/twitter/authorization_url/test_login_twitter_authorization_url.py b/tests/handlers/login/twitter/authorization_url/test_login_twitter_authorization_url.py
@@ -33,5 +33,5 @@ def test_exec_main_ng(self):
             self.assertEqual(response['statusCode'], 500)
             self.assertEqual(
                 json.loads(response['body']),
-                {'message': 'Internal server error'}
+                {'message': 'Internal server error: LoginTwitterAuthorizationUrl'}
             )
diff --git a/tests/handlers/login/twitter/index/test_login_twitter_index.py b/tests/handlers/login/twitter/index/test_login_twitter_index.py
@@ -276,7 +276,7 @@ def test_main_ng_with_awsexception_and_existing_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginTwitterIndex'
                 }
             )
 
@@ -309,6 +309,6 @@ def test_main_ng_with_awsexception_and_new_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginTwitterIndex'
                 }
             )
diff --git a/tests/handlers/login/yahoo/authorization_url/test_login_yahoo_authorization_url.py b/tests/handlers/login/yahoo/authorization_url/test_login_yahoo_authorization_url.py
@@ -34,7 +34,7 @@ def test_exec_main_ng_with_clienterror(self):
             self.assertEqual(response['statusCode'], 500)
             self.assertEqual(
                 json.loads(response['body']),
-                {'message': 'Internal server error'}
+                {'message': 'Internal server error: LoginYahooAuthorizationUrl'}
             )
 
     def test_exec_main_ng_with_yahoo(self):
@@ -48,5 +48,5 @@ def test_exec_main_ng_with_yahoo(self):
             self.assertEqual(response['statusCode'], 500)
             self.assertEqual(
                 json.loads(response['body']),
-                {'message': 'Internal server error'}
+                {'message': 'Internal server error: LoginYahooAuthorizationUrl'}
             )
diff --git a/tests/handlers/login/yahoo/index/test_login_yahoo_index.py b/tests/handlers/login/yahoo/index/test_login_yahoo_index.py
@@ -332,7 +332,7 @@ def test_main_ng_with_awsexception_and_existing_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginYahooIndex'
                 }
             )
 
@@ -372,6 +372,6 @@ def test_main_ng_with_awsexception_and_new_user(self):
             self.assertEqual(
                 json.loads(response['body']),
                 {
-                    'message': 'Internal server error'
+                    'message': 'Internal server error: LoginYahooIndex'
                 }
             )
diff --git a/...handlers/me/articles/drafts/article_id/create/test_me_article_drafts_article_id_create.py b/...handlers/me/articles/drafts/article_id/create/test_me_article_drafts_article_id_create.py
@@ -92,7 +92,7 @@ def test_main_with_internal_server_error_on_create_article_info(self):
         article_content_after = self.article_content_table.scan()['Items']
 
         self.assertEqual(response['statusCode'], 500)
-        self.assertEqual(json.loads(response['body'])['message'], 'Internal server error')
+        self.assertEqual(json.loads(response['body'])['message'], 'Internal server error: MeArticlesDraftsArticleIdCreate')
         self.assertEqual(len(article_info_after) - len(article_info_before), 0)
         self.assertEqual(len(article_content_after) - len(article_content_before), 0)
 

diff --git a/tests/handlers/me/articles/drafts/create/test_me_article_drafts_create.py b/tests/handlers/me/articles/drafts/create/test_me_article_drafts_create.py
@@ -146,7 +146,7 @@ def test_main_with_internal_server_error_on_create_article_info(self):
         article_content_after = self.article_content_table.scan()['Items']
 
         self.assertEqual(response['statusCode'], 500)
-        self.assertEqual(json.loads(response['body'])['message'], 'Internal server error')
+        self.assertEqual(json.loads(response['body'])['message'], 'Internal server error: MeArticlesDraftsCreate')
         self.assertEqual(len(article_info_after) - len(article_info_before), 0)
         self.assertEqual(len(article_content_after) - len(article_content_before), 0)