Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Lower display is blank with edges wider than image #733

Closed
Adrienne200 opened this issue Dec 4, 2024 · 1 comment · Fixed by #737
Closed

[BUG] Lower display is blank with edges wider than image #733

Adrienne200 opened this issue Dec 4, 2024 · 1 comment · Fixed by #737

Comments

@Adrienne200
Copy link

AYAB software version: 1.0 Beta3
Computer/OS: Mac
Knitting machine: 930
AYAB hardware: shield

If you set start and stop edges that are wider than the image, and the stop edge is anywhere to the left of needle Right2, it can get into a situation where it is not displaying anything in the lower display, and not updating the upper display, though it is knitting correctly.

Steps to reproduce the behavior:

  1. Start with all settings at default
  2. Open test image uc3_3-x15.png
  3. Set the edges. to L34 - R2, so the 30st image is centered in 36 stitches
  4. Click Simulate, or Knit.
  5. If you actually (air)knit it, it does knit in the right place
  6. Wait for Simulate to finish, it is actually doing something, you get the ending sounds.

Expected: It should step through and display, with the image centered within its area and 3 squares of white on each side.
Actual: the lower display is blank, and the upper display doesn't step up. The needle numbers displayed in the lower box are from the last time it worked. It does knit in the right place.

@Adrienne200 Adrienne200 added this to the 1.0.0 milestone Dec 4, 2024
@Adrienne200 Adrienne200 changed the title [BUG] [BUG] Lower display is blank with edges wider than image Dec 4, 2024
@jonathanperret jonathanperret moved this to Needs Testing in AYAB 1.0.0 Release Tracking Dec 4, 2024
@jonathanperret
Copy link
Contributor

🛎 A proposed fix for this is in #737 and can be tested in the release referenced there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants