-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux build: bump to Python 3.11.11 #742
Linux build: bump to Python 3.11.11 #742
Conversation
python-appimage removed the 3.11.10 release from their repo.
WalkthroughThe pull request modifies the GitHub Actions workflow in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/build-multi-os.yml (1)
443-444
: Consider future alignment of Python versions across platforms.While the current patch-level differences between platforms (3.11.9 for Windows/macOS vs 3.11.11 for Linux) should maintain compatibility, consider aligning these versions in a future update if possible. This would ensure consistent behavior across all platforms.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-multi-os.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/build-multi-os.yml (1)
443-444
: LGTM: Python version update is necessary and minimal.
The update from Python 3.11.10 to 3.11.11 for Linux builds is necessary due to the removal of 3.11.10 from the python-appimage repository. This patch-level version bump maintains compatibility while ensuring the build process continues to work.
You're right bot, but I prefer minimizing the impact of this change for now. If 3.11.11 fails on Linux, it won't be worse than the current absence of a build. But if 3.11.11 breaks something on Mac or Windows, we'll have to fix it right away when we could have just stayed on a known working version. |
Problem
python-appimage removed the 3.11.10 release from their repo.
Proposed solution
Like we did last time, we bump the version of Python used for the Linux build.
This is not satisfying but right now I don't have a better idea.
Summary by CodeRabbit
New Features
Improvements
Documentation