Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental use of PCN test data for validation? #16

Open
lucasbrynte opened this issue Dec 7, 2022 · 1 comment
Open

Accidental use of PCN test data for validation? #16

lucasbrynte opened this issue Dec 7, 2022 · 1 comment

Comments

@lucasbrynte
Copy link

Hi!

I just wanted to report what I think might be a mistake in using the PCN test data not only for testing, but also for validation. Shouldn't utils.data_loaders.DatasetSubset.TEST in the following rather be utils.data_loaders.DatasetSubset.VAL..?

val_data_loader = torch.utils.data.DataLoader(dataset=test_dataset_loader.get_dataset(
utils.data_loaders.DatasetSubset.TEST),

Regards,
Lucas

@AllenXiangX
Copy link
Owner

Hi,
Thank you for your interest in our work. To have a fair comparisn with previous work on the PCN benchmark, the model is trained on the training set and validated on the test set as most previous work does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants