Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog #87 #158

Open
wants to merge 2 commits into
base: feat_recomb_new_changelog
Choose a base branch
from

Conversation

XingerTang
Copy link
Contributor

@XingerTang XingerTang commented Jan 11, 2024

#87 #154

Adapted from numpy's changelog, upcoming changes, and release notes.

The reason for using the templates and structures from Numpy instead of msprime is that Numpy also builds the documentation using Sphinx, while msprime builds the documentation in its own way. So Numpy is using .rst files while msprime is using .md file. As we are using .rst and Sphinx now, I think it is better to follow what Numpy did.

The preview for the release notes page of the updated documentation is available at https://xingertang-alphapeel.readthedocs.io/en/latest/release/1.2.0-notes.html.

As Numpy did not put changelog and upcoming changes inside its documentation, I also didn't add it, but we can change it if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this where we will put things before they go onto version release notes? Maybe we just work with version release notes file (numpy is a much larger project so they need to announce changes)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to release notes file - for simplicity

Copy link
Member

@gregorgorjanc gregorgorjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XingerTang minor comments. This looks fantastic otherwise. I wonder if it’s almost too much, but time will tell! I like it. Now we just need to ensure we build it gradually with each PR!

Copy link
Member

@gregorgorjanc gregorgorjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gregorgorjanc
Copy link
Member

@XingerTang I lost track on this PR too. Should we merge in and work from this point onwards?

@XingerTang
Copy link
Contributor Author

@gregorgorjanc I think it might be because the changes are still ongoing so we can't finish it until all the changes have completed.

@gregorgorjanc
Copy link
Member

@XingerTang I am thinking that we should be growing changelog with each new major PR/change so that we don't have these multiple PR open and wondering what needs doing in each one.

What are the major things that we are currently working on? Please list these in the changelog as work in progress and then we merge this in, and update the changelog when those work in progress PR/changes are merged into the devel branch.

@gregorgorjanc
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants