Extend authorized parties with instance delegations #2173
andreasisnesbuild-and-analyze.yml
on: pull_request
Build and Test
43s
Analyze
4m 22s
Annotations
9 errors and 10 warnings
|
Build and Test:
src/Altinn.AccessManagement.Persistence/DelegationMetadataRepo.cs#L1317
inheritdoc should be used with inheriting class (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1648.md)
|
|
|
|
Build and Test:
test/Altinn.AccessManagement.Tests/Mocks/DelegationMetadataRepositoryMock.cs#L17
'DelegationMetadataRepositoryMock' does not implement interface member 'IDelegationMetadataRepository.GetAllCurrentReceivedInstanceDelegations(List<Guid>, CancellationToken)'
|
|
Build and Test:
src/Altinn.AccessManagement.Persistence/DelegationMetadataRepo.cs#L1317
inheritdoc should be used with inheriting class (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1648.md)
|
|
|
|
Build and Test:
test/Altinn.AccessManagement.Tests/Mocks/DelegationMetadataRepositoryMock.cs#L17
'DelegationMetadataRepositoryMock' does not implement interface member 'IDelegationMetadataRepository.GetAllCurrentReceivedInstanceDelegations(List<Guid>, CancellationToken)'
|
|
Build and Test
Process completed with exit code 1.
|
|
Analyze:
test/Altinn.AccessManagement.Tests/Mocks/DelegationMetadataRepositoryMock.cs#L17
'DelegationMetadataRepositoryMock' does not implement interface member 'IDelegationMetadataRepository.GetAllCurrentReceivedInstanceDelegations(List<Guid>, CancellationToken)'
|
|
Analyze:
test/Altinn.AccessManagement.Tests/Mocks/DelegationMetadataRepositoryMock.cs#L17
'DelegationMetadataRepositoryMock' does not implement interface member 'IDelegationMetadataRepository.GetAllCurrentReceivedInstanceDelegations(List<Guid>, CancellationToken)'
|
|
Analyze:
src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs#L188
Define a constant instead of using this literal 'appInstanceDelegationRequest.Resource' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Analyze:
src/Altinn.AccessManagement.Core/Repositories/Interfaces/IDelegationMetadataRepository.cs#L67
Method has 8 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107)
|
|
Analyze:
src/Altinn.AccessManagement.Core/Services/AppsInstanceDelegationService.cs#L220
'delegableRights' is null on at least one execution path. (https://rules.sonarsource.com/csharp/RSPEC-2259)
|
|
Analyze:
src/Altinn.AccessManagement.Core/Services/AuthorizedPartiesService.cs#L175
Refactor this method to reduce its Cognitive Complexity from 70 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Analyze:
src/Altinn.AccessManagement.Integration/Clients/AltinnRolesClient.cs#L54
Either log this exception and handle it, or rethrow it with some contextual information. (https://rules.sonarsource.com/csharp/RSPEC-2139)
|
|
Analyze:
src/Altinn.AccessManagement.Integration/Clients/AltinnRolesClient.cs#L79
Either log this exception and handle it, or rethrow it with some contextual information. (https://rules.sonarsource.com/csharp/RSPEC-2139)
|
|
Analyze:
src/Altinn.AccessManagement.Integration/Clients/AltinnRolesClient.cs#L105
Either log this exception and handle it, or rethrow it with some contextual information. (https://rules.sonarsource.com/csharp/RSPEC-2139)
|
|
Analyze:
src/Altinn.AccessManagement.Persistence/DelegationMetadataRepo.cs#L1318
All 'GetAllDelegationChangesForAuthorizedParties' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136)
|
|
Analyze:
src/Altinn.AccessManagement.Persistence/DelegationMetadataRepository.cs#L93
Define a constant instead of using this literal '_offeredByPartyId' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Analyze:
src/Altinn.AccessManagement.Persistence/DelegationMetadataRepository.cs#L94
Define a constant instead of using this literal '_coveredByUserId' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|