Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PIP API with instance delegation lookup support #859

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Update PIP API with instance delegation lookup support #859

merged 4 commits into from
Oct 28, 2024

Conversation

jonkjetiloye
Copy link
Member

@jonkjetiloye jonkjetiloye commented Oct 24, 2024 •
edited
Loading

Description

Related Issue(s)

Developer/Reviewer Checklist

  • Your code builds clean without any errors or warnings
  • No changes to config/appsettings or environment variables created in separate linked PR
  • Manual testing done (required)
  • Relevant integration test added (required for functional changes)
  • Relevant automated test added (required for functional changes)
  • All integration tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

TheTechArch
TheTechArch approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@TheTechArch TheTechArch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg har ikke studert endringen på selve instance delegering, men gitt min forståelse av hvordan policy lages og verdier satt ser det riktig ut for uthentin

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
2 Accepted issues

Measures
0 Security Hotspots
79.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jonkjetiloye jonkjetiloye merged commit f09d845 into main Oct 28, 2024
9 checks passed
@jonkjetiloye jonkjetiloye deleted the feature/am-837_PIPAPI_InstanceDelegations branch October 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTechArch TheTechArch TheTechArch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonkjetiloye @TheTechArch