Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable blob versioning for storage account #962

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Enable blob versioning for storage account #962

merged 3 commits into from
Sep 27, 2024

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Sep 26, 2024

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link

github-actions bot commented Sep 26, 2024

Terraform environment prod

Format and Style 🖌success

Initialization ⚙️success

Validation 🤖success

Validation Output

Success! The configuration is valid.


Plan 📖success

Show Plan

[Lines containing Refreshing state removed]
[Maybe further truncated see logs for complete plan output]
Acquiring state lock. This may take a few moments...
data.azuread_client_config.current: Reading...
data.azuread_client_config.current: Read complete after 0s [id=cd0026d8-283b-4a55-9bfa-d0ef4a8ba21c-c217a3ea-402f-4886-ace5-478db72ab4c9-cc75a1cc-d6a1-4530-828f-86832ce91b9b]
data.azuread_application_published_app_ids.well_known: Reading...
data.azuread_application_published_app_ids.well_known: Read complete after 0s [id=appIds]
data.azuread_directory_object.current: Reading...
data.azuread_service_principal.msgraph: Reading...
data.azuread_directory_object.current: Read complete after 0s [id=cc75a1cc-d6a1-4530-828f-86832ce91b9b]
data.azurerm_role_definition.storage_blob_reader_data_access: Reading...
data.azurerm_role_definition.contributor: Reading...
data.azurerm_role_definition.storage_blob_reader_data_access: Read complete after 0s [id=/providers/Microsoft.Authorization/roleDefinitions/c12c1c16-33a1-487b-954d-41c89c60f349]
data.azurerm_role_definition.reader: Reading...
data.azurerm_resource_group.tfstate: Reading...
data.azurerm_role_definition.storage_blob_data_owner: Reading...
data.azurerm_role_definition.contributor: Read complete after 0s [id=/providers/Microsoft.Authorization/roleDefinitions/b24988ac-6180-42a0-ab88-20f7382dd24c]
data.azurerm_role_definition.user_access_administrator: Reading...
data.azurerm_role_definition.reader: Read complete after 0s [id=/providers/Microsoft.Authorization/roleDefinitions/acdd72a7-3385-48ef-bd42-f606fba81ae7]
data.azurerm_subscription.current: Reading...
data.azurerm_role_definition.user_access_administrator: Read complete after 0s [id=/providers/Microsoft.Authorization/roleDefinitions/18d7d88d-d35e-4fb5-a5c3-7773c20a72d9]
data.azurerm_role_definition.storage_blob_data_owner: Read complete after 0s [id=/providers/Microsoft.Authorization/roleDefinitions/b7e6dc6d-f1e8-4753-8033-0f276bb0955b]
data.azurerm_subscription.current: Read complete after 0s [id=/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2]
data.azuread_service_principal.msgraph: Read complete after 0s [id=b9d7b3d8-a063-4e34-89d9-15db56e22d42]
data.azurerm_resource_group.tfstate: Read complete after 0s [id=/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg]
data.azuread_service_principal.current[0]: Reading...
data.azuread_service_principal.current[0]: Read complete after 0s [id=cc75a1cc-d6a1-4530-828f-86832ce91b9b]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # azuread_application.administrator will be updated in-place
  ~ resource "azuread_application" "administrator" {
      ~ display_name                   = "GitHub: altinn/altinn-platform - Admin" -> "GitHub: Altinn/altinn-platform - Admin"
        id                             = "/applications/005b1c70-6fa7-4205-9fa1-8b7a53713238"
        tags                           = []
        # (15 unchanged attributes hidden)

      - required_resource_access {
          - resource_app_id = "00000003-0000-0000-c000-000000000000" -> null

          - resource_access {
              - id   = "62a82d76-70ea-41e2-9197-370581804d09" -> null
              - type = "Role" -> null
            }
          - resource_access {
              - id   = "1bfefb4e-e0b5-418b-a88f-73c46d2cc8e9" -> null
              - type = "Role" -> null
            }
        }

        # (6 unchanged blocks hidden)
    }

  # azuread_application.reader will be updated in-place
  ~ resource "azuread_application" "reader" {
      ~ display_name                   = "GitHub: altinn/altinn-platform - Reader" -> "GitHub: Altinn/altinn-platform - Reader"
        id                             = "/applications/f2259af8-0975-4e83-925f-3ccdf18da571"
        tags                           = []
        # (15 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }

  # azuread_application_api_access.reader_msgraph will be created
  + resource "azuread_application_api_access" "reader_msgraph" {
      + api_client_id  = "00000003-0000-0000-c000-000000000000"
      + application_id = "/applications/f2259af8-0975-4e83-925f-3ccdf18da571"
      + id             = (known after apply)
      + role_ids       = [
          + "5b567255-7703-4780-807c-7be8301ae99b",
          + "9a5d68dd-52b0-4cc2-bd40-abcf44ac3a30",
        ]
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["at21"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "f6be0dc6-d3e7-410c-b97d-34effbad46f2" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'at21' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'at21' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.at21" -> "github.Altinn.altinn-platform.environment.at21" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/f6be0dc6-d3e7-410c-b97d-34effbad46f2" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:at21" -> "repo:Altinn/altinn-platform:environment:at21"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["at22"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "a7efa549-82be-4b7b-bc2d-39336f984103" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'at22' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'at22' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.at22" -> "github.Altinn.altinn-platform.environment.at22" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/a7efa549-82be-4b7b-bc2d-39336f984103" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:at22" -> "repo:Altinn/altinn-platform:environment:at22"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["at23"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "2ece2fec-a222-4a38-8a0f-27bdfb160338" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'at23' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'at23' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.at23" -> "github.Altinn.altinn-platform.environment.at23" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/2ece2fec-a222-4a38-8a0f-27bdfb160338" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:at23" -> "repo:Altinn/altinn-platform:environment:at23"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["at24"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "20394998-885a-460d-9794-136409e3a014" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'at24' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'at24' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.at24" -> "github.Altinn.altinn-platform.environment.at24" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/20394998-885a-460d-9794-136409e3a014" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:at24" -> "repo:Altinn/altinn-platform:environment:at24"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["at25"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "48074d9e-3975-440a-ad6f-00714751ac8f" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'at25' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'at25' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.at25" -> "github.Altinn.altinn-platform.environment.at25" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/48074d9e-3975-440a-ad6f-00714751ac8f" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:at25" -> "repo:Altinn/altinn-platform:environment:at25"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["dev"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "56691ab1-080e-4a12-95a5-e578a8d1cc4b" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'dev' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'dev' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.dev" -> "github.Altinn.altinn-platform.environment.dev" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/56691ab1-080e-4a12-95a5-e578a8d1cc4b" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:dev" -> "repo:Altinn/altinn-platform:environment:dev"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["prod"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "7d788d72-d8fb-4517-9709-23fe17935655" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'prod' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'prod' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.prod" -> "github.Altinn.altinn-platform.environment.prod" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/7d788d72-d8fb-4517-9709-23fe17935655" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:prod" -> "repo:Altinn/altinn-platform:environment:prod"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["staging"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "5c870907-bcc2-4142-be68-88fb99eb2caf" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'staging' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'staging' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.staging" -> "github.Altinn.altinn-platform.environment.staging" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/5c870907-bcc2-4142-be68-88fb99eb2caf" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:staging" -> "repo:Altinn/altinn-platform:environment:staging"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["test"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "22218dde-c959-4878-824d-f16af0245431" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'test' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'test' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.test" -> "github.Altinn.altinn-platform.environment.test" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/22218dde-c959-4878-824d-f16af0245431" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:test" -> "repo:Altinn/altinn-platform:environment:test"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["tt02"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "f65f0a1e-1997-4b7d-a9ae-2c83508ab58f" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'tt02' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'tt02' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.tt02" -> "github.Altinn.altinn-platform.environment.tt02" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/f65f0a1e-1997-4b7d-a9ae-2c83508ab58f" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:tt02" -> "repo:Altinn/altinn-platform:environment:tt02"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_admin["yt01"] must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_admin" {
      ~ application_object_id = "005b1c70-6fa7-4205-9fa1-8b7a53713238" -> (known after apply)
      ~ credential_id         = "0622fe18-e790-447c-a293-abffa48c97a8" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment 'yt01' from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment 'yt01' from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.yt01" -> "github.Altinn.altinn-platform.environment.yt01" # forces replacement
      ~ id                    = "005b1c70-6fa7-4205-9fa1-8b7a53713238/federatedIdentityCredential/0622fe18-e790-447c-a293-abffa48c97a8" -> (known after apply)
      ~ subject               = "repo:altinn/altinn-platform:environment:yt01" -> "repo:Altinn/altinn-platform:environment:yt01"
        # (3 unchanged attributes hidden)
    }

  # azuread_application_federated_identity_credential.oidc_environments_reader must be replaced
-/+ resource "azuread_application_federated_identity_credential" "oidc_environments_reader" {
      ~ application_object_id = "f2259af8-0975-4e83-925f-3ccdf18da571" -> (known after apply)
      ~ credential_id         = "7f382587-9e15-4bf1-9769-dbdb51168bf8" -> (known after apply)
      ~ description           = "Allow GitHub actions run within the context of environment reader from the repository https://github.com/altinn/altinn-platform to have access to the app registration" -> "Allow GitHub actions run within the context of environment reader from the repository https://github.com/Altinn/altinn-platform to have access to the app registration"
      ~ display_name          = "github.altinn.altinn-platform.environment.reader" -> "github.Altinn.altinn-platform.environment.reader" # forces replacement
      ~ id                    = "f2259af8-0975-4e83-925f-3ccdf18da571/federatedIdentityCredential/7f382587-9e15-4bf1-9769-dbdb51168bf8" -> (known after apply)
        # (4 unchanged attributes hidden)
    }

  # azurerm_app_configuration.state will be updated in-place
  ~ resource "azurerm_app_configuration" "state" {
        id                         = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.AppConfiguration/configurationStores/altinnterraformappconf02"
        name                       = "altinnterraformappconf02"
      ~ tags                       = {
          - "costcenter" = "altinn3"
          - "createdAt"  = "09-07-2024 09:55:43 UTC"
          - "createdBy"  = "Bengt Rino Fredh"
          - "modifiedAt" = "26-09-2024 12:22:20 UTC"
          - "modifiedBy" = "GitHub: altinn/altinn-platform - Admin"
          - "repository" = "github.com/altinn/altinn-platform"
          - "solution"   = "platform"
        } -> (known after apply)
        # (11 unchanged attributes hidden)
    }

  # azurerm_role_assignment.product_reader_storage_blob_reader_data_access must be replaced
-/+ resource "azurerm_role_assignment" "product_reader_storage_blob_reader_data_access" {
      ~ id                               = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.Storage/storageAccounts/altinnterraformstorage02/blobServices/default/containers/tfstates/providers/Microsoft.Authorization/roleAssignments/9acadb4f-509b-6d03-6a9b-60d9090dc04e" -> (known after apply)
      ~ name                             = "9acadb4f-509b-6d03-6a9b-60d9090dc04e" -> (known after apply)
      ~ principal_id                     = "185ee3a4-7906-4c2d-9582-80526f094039" -> "cbbd7c6d-d6cb-4818-a21d-29e4d91b73f6" # forces replacement
      ~ principal_type                   = "Group" -> (known after apply)
      ~ role_definition_id               = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/providers/Microsoft.Authorization/roleDefinitions/c12c1c16-33a1-487b-954d-41c89c60f349" -> (known after apply)
      ~ scope                            = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.Storage/storageAccounts/altinnterraformstorage02/blobServices/default/containers/tfstates" -> "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.Storage/storageAccounts/altinnterraformstorage02" # forces replacement
      + skip_service_principal_aad_check = (known after apply)
        # (1 unchanged attribute hidden)
    }

  # azurerm_role_assignment.product_readers_storage_blob_owner must be replaced
-/+ resource "azurerm_role_assignment" "product_readers_storage_blob_owner" {
      ~ condition                        = <<-EOT # forces replacement
            (
             (
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/write'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/add/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/runAsSuperUser/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/tags/write'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/delete'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/deleteBlobVersion/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/immutableStorage/runAsSuperUser/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/move/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/manageOwnership/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/permanentDelete/action'})
              AND
              !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/modifyPermissions/action'})
            )
            
             OR 
             (
          -   @Resource[Microsoft.Storage/storageAccounts/blobServices/containers/blobs:path] StringStartsWith 'github.com/altinn/altinn-platform/'
          +   @Resource[Microsoft.Storage/storageAccounts/blobServices/containers/blobs:path] StringStartsWith 'github.com/Altinn/altinn-platform/'
             )
            )
        EOT
      ~ id                               = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.Storage/storageAccounts/altinnterraformstorage02/blobServices/default/containers/tfstates/providers/Microsoft.Authorization/roleAssignments/160cace2-256a-fbe7-c513-6b7384bcd423" -> (known after apply)
      ~ name                             = "160cace2-256a-fbe7-c513-6b7384bcd423" -> (known after apply)
      ~ principal_type                   = "Group" -> (known after apply)
      ~ role_definition_id               = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/providers/Microsoft.Authorization/roleDefinitions/b7e6dc6d-f1e8-4753-8033-0f276bb0955b" -> (known after apply)
      + skip_service_principal_aad_check = (known after apply)
        # (4 unchanged attributes hidden)
    }

  # azurerm_storage_account.backend will be updated in-place
  ~ resource "azurerm_storage_account" "backend" {
        id                                = "/subscriptions/d43d5057-8389-40d5-88c4-04db9275cbf2/resourceGroups/terraform-rg/providers/Microsoft.Storage/storageAccounts/altinnterraformstorage02"
        name                              = "altinnterraformstorage02"
      ~ tags                              = {
          - "costcenter" = "altinn3"
          - "createdAt"  = "09-07-2024 09:55:43 UTC"
          - "createdBy"  = "Bengt Rino Fredh"
          - "modifiedAt" = "26-09-2024 12:22:20 UTC"
          - "modifiedBy" = "GitHub: altinn/altinn-platform - Admin"
          - "repository" = "github.com/altinn/altinn-platform"
          - "solution"   = "platform"
        } -> (known after apply)
        # (36 unchanged attributes hidden)

      ~ blob_properties {
          ~ versioning_enabled            = false -> true
            # (3 unchanged attributes hidden)
        }
    }

Plan: 15 to add, 4 to change, 14 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan.out

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan.out"
Releasing state lock. This may take a few moments...

Context Values
Pusher @tjololo
Action push
Working Directory ./infrastructure/products
State File github.com/altinn/altinn-platform/environments/prod/products.tfstate
Plan File github.com_altinn_altinn-platform_environments_prod_products.tfstate.tfplan

Copy link
Member

@bengtfredh bengtfredh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjololo tjololo merged commit 2f7fb26 into main Sep 27, 2024
4 checks passed
@tjololo tjololo deleted the enable-versioning branch September 27, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants