Remove 3 unnecessary interfaces

Altinn · Oct 24, 2024 · f8fa0e4 · f8fa0e4
1 parent 23151bb
commit f8fa0e4
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 134 deletions.
diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactDetailsSnapshot.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactDetailsSnapshot.cs
diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactPreferences.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactPreferences.cs
diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactPreferencesSnapshot.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/IPersonContactPreferencesSnapshot.cs
diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactDetailsSnapshot.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactDetailsSnapshot.cs
@@ -5,7 +5,7 @@ namespace Altinn.Profile.Core.Person.ContactPreferences;
 /// <summary>
 /// Represents a snapshot of the contact details retrieved from the changes log.
 /// </summary>
-public record PersonContactDetailsSnapshot : IPersonContactDetailsSnapshot
+public record PersonContactDetailsSnapshot
 {
     /// <summary>
     /// Gets the email address of the person.

diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactPreferences.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactPreferences.cs
@@ -5,7 +5,7 @@ namespace Altinn.Profile.Core.Person.ContactPreferences;
 /// <summary>
 /// Represents a person's contact details.
 /// </summary>
-public record PersonContactPreferences : IPersonContactPreferences
+public record PersonContactPreferences
 {
     /// <summary>
     /// Gets the email address of the person.

diff --git a/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactPreferencesSnapshot.cs b/src/Altinn.Profile.Core/Person.ContactPreferences/PersonContactPreferencesSnapshot.cs
@@ -5,7 +5,7 @@ namespace Altinn.Profile.Core.Person.ContactPreferences;
 /// <summary>
 /// Represents a log of changes to a person's contact preferences, including contact information, language preference, notification status, and other details.
 /// </summary>
-public class PersonContactPreferencesSnapshot : IPersonContactPreferencesSnapshot
+public class PersonContactPreferencesSnapshot
 {
     /// <summary>
     /// Gets the contact information details of the person.

diff --git a/src/Altinn.Profile.Integrations/ServiceCollectionExtensions.cs b/src/Altinn.Profile.Integrations/ServiceCollectionExtensions.cs
@@ -97,8 +97,6 @@ public static void AddMaskinportenClient(this IServiceCollection services, IConf
         }
 
         services.AddScoped<IContactRegisterService, ContactRegisterService>();
-        services.AddScoped<IPersonContactPreferencesSnapshot, PersonContactPreferencesSnapshot>();
-        services.AddScoped<IPersonContactDetailsSnapshot, PersonContactDetailsSnapshot>();
 
         services.AddSingleton(contactRegisterSettings);
         services.AddMaskinportenHttpClient<SettingsJwkClientDefinition, IContactRegisterHttpClient, ContactRegisterHttpClient>(contactRegisterSettings.MaskinportenSettings);

diff --git a/src/Altinn.Profile/UseCases/PersonContactDetailsRetriever.cs b/src/Altinn.Profile/UseCases/PersonContactDetailsRetriever.cs
@@ -53,7 +53,7 @@ public async Task<Result<PersonContactDetailsLookupResult, bool>> RetrieveAsync(
     /// <param name="contactPreferences">The person contact details to map.</param>
     /// <returns>The mapped <see cref="PersonContactDetails"/>.</returns>
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="contactPreferences"/> is null.</exception>
-    private PersonContactDetails MapToContactDetails(IPersonContactPreferences contactPreferences)
+    private PersonContactDetails MapToContactDetails(PersonContactPreferences contactPreferences)
     {
         ArgumentNullException.ThrowIfNull(contactPreferences);
 

diff --git a/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonServiceTests.cs b/test/Altinn.Profile.Tests/Profile.Integrations/Person/PersonServiceTests.cs
@@ -85,7 +85,7 @@ public async Task GetContactDetailsAsync_WhenAllNumbersValidAndAllContactsFound_
 
         // Assert
         IEnumerable<string>? unmatchedNationalIdentityNumbers = null;
-        IEnumerable<IPersonContactPreferences>? matchedPersonContactDetails = null;
+        IEnumerable<PersonContactPreferences>? matchedPersonContactDetails = null;
 
         result.Match(
             success =>
@@ -141,7 +141,7 @@ public async Task GetContactDetailsAsync_WhenMultipleNationalIdentityNumbersAreP
 
         _mapperMock.Setup(x => x.Map<PersonContactPreferences>(firstRandomPerson))
                    .Returns(firstMappedContactDetails);
-        _mapperMock.Setup(x => x.Map<IPersonContactPreferences>(secondRandomPerson))
+        _mapperMock.Setup(x => x.Map<PersonContactPreferences>(secondRandomPerson))
                    .Returns(secondMappedContactDetails);
 
         _personRepositoryMock
@@ -157,7 +157,7 @@ public async Task GetContactDetailsAsync_WhenMultipleNationalIdentityNumbersAreP
 
         // Assert
         IEnumerable<string>? unmatchedNationalIdentityNumbers = null;
-        IEnumerable<IPersonContactPreferences>? matchedPersonContactDetails = null;
+        IEnumerable<PersonContactPreferences>? matchedPersonContactDetails = null;
 
         result.Match(
             success =>
@@ -203,7 +203,7 @@ public async Task GetContactDetailsAsync_WhenNationalIdentityNumberIsInvalid_Ret
 
         // Assert
         IEnumerable<string>? unmatchedNationalIdentityNumbers = null;
-        IEnumerable<IPersonContactPreferences>? matchedPersonContactDetails = null;
+        IEnumerable<PersonContactPreferences>? matchedPersonContactDetails = null;
         result.Match(
           success =>
           {
@@ -256,7 +256,7 @@ public async Task GetContactDetailsAsync_WhenNationalIdentityNumberIsValid_Retur
 
         // Assert
         IEnumerable<string>? unmatchedNationalIdentityNumbers = null;
-        IEnumerable<IPersonContactPreferences>? matchedPersonContactDetails = null;
+        IEnumerable<PersonContactPreferences>? matchedPersonContactDetails = null;
 
         result.Match(
             success =>
@@ -283,7 +283,7 @@ public async Task GetContactDetailsAsync_WhenNationalIdentityNumberIsValid_Retur
     /// </summary>
     /// <param name="expected">The expected contact preferences.</param>
     /// <param name="actualContactDetails">The actual contact details.</param>
-    private static void AssertContactDetails(PersonContactPreferences expected, IEnumerable<IPersonContactPreferences> actualContactDetails)
+    private static void AssertContactDetails(PersonContactPreferences expected, IEnumerable<PersonContactPreferences> actualContactDetails)
     {
         var contactDetails = actualContactDetails.FirstOrDefault(detail => detail.NationalIdentityNumber == expected.NationalIdentityNumber);