Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the Profile solution into multiple projects using typical clean architecture #194

Closed
2 tasks
Tracked by #176
SandGrainOne opened this issue Sep 23, 2024 · 2 comments
Closed
2 tasks
Tracked by #176
Assignees
Labels
kind/user-story Used for issues that describes functionality for our users.

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Sep 23, 2024

Description

Split in multiple modules/sub-modules and a repository-project (DbTools++).

Sperarate projects for: Repository, Integration, Core and API

See the repos of Notifications or Registry for inspiration.

Additional Information

No response

Tasks

  • Reorganize solution into src and tests

Acceptance Criterias

  • The Profile solution has projects, each covering one area of clean architecture.
@SandGrainOne SandGrainOne added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Sep 23, 2024
@hggutvik hggutvik self-assigned this Sep 24, 2024
@hggutvik
Copy link
Contributor

hggutvik commented Sep 27, 2024

Using Clean Architecture with ASP.NET Core 8 | .NET Conf 2023 and this Medium article as references, the "Infrastructure" project/layer (called Integrations in this repo) seems to be appropriate for holding all data access implementations, including repositories, caching, and clients for external APIs,

From this, we are deciding to try placing the clients/repositories in the Integrations project

@SandGrainOne SandGrainOne removed the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Oct 3, 2024
@SandGrainOne
Copy link
Member Author

Refactoring requires regression testing and I put my trust in the automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users.
Projects
None yet
Development

No branches or pull requests

2 participants