Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The contact and reservation registry synchronization job should handle more than 1000 changes #230

Open
2 tasks
SandGrainOne opened this issue Oct 28, 2024 · 0 comments
Assignees
Labels
kind/user-story Used for issues that describes functionality for our users.

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Oct 28, 2024

Description

The current implementation of the synchronization job with the contact and reservation registry handles just a single list of changes. This limits the job at 1000 persons being updated/created per execution. We want this to be changed to that the job can run for longer to handle more changes.

Additional Information

No response

Tasks

  • Implement a loop around the current implementation where it will continue to fetch more changes as long as there are changes to get
    • The assumption is that we can see if a page has 1000 persons and assume that this means there are more pages to retrieve. This is unless there is a more explicit paging mechanism provided by the API. If so use that instead.
    • Store the last change number every iteration so that we can continue from last success if we need to restart the job

Acceptance Criterias

  • The sync job iterates over all available changes instead of only the 1000 we get on first request
@SandGrainOne SandGrainOne added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Oct 28, 2024
@SandGrainOne SandGrainOne self-assigned this Oct 28, 2024
@SandGrainOne SandGrainOne removed the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users.
Projects
None yet
Development

No branches or pull requests

1 participant