API endpoint for getting UserProfile by username #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#104 Adds an API endpoint in altinn-profile: profile/api/v1/users/?username={username} which consumes the newly added SBL bridge API: /sblbridge/profile/api/users/?username={username}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (!response.IsSuccessStatusCode) | ||
| { | ||
| _logger.LogError("Getting user {username} failed with {statusCode}", username, response.StatusCode); |
Check failure
Code scanning / CodeQL
Log entries created from user input High
added 3 commits
November 2, 2023 15:44
- Simplified implementation to a single POST endpoint with lookup model
|
Kudos, SonarCloud Quality Gate passed! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new API controller to altinn-profile with endpoint for internal use (from e.g. Authorization) for lookup of UserProfile:
POST profile/api/v1/internal/user/which takes in a new UserProfileLookup model where one of the available user identifiers:
UserId
Username
SSN (or Dnr)
must be provided for performing the lookup of UserProfile for a given user.
New service and client implementation has been added for lookup by username which consumes the newly added SBL bridge API:
/sblbridge/profile/api/users/?username={username}Related Issue(s)
Verification
Documentation