Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed prop name ContactPointList -> ContactPointsList #147

Merged
merged 1 commit into from
Apr 24, 2024
Merged

changed prop name ContactPointList -> ContactPointsList #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Altinn.Profile.Core/User.ContactPoints/UserContactPointService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public async Task<Result<UserContactPointsList, bool>> GetContactPoints(List<str
result.Match(
profile =>
{
resultList.ContactPointList.Add(
resultList.ContactPointsList.Add(
new UserContactPoints()
{
UserId = profile.PartyId,
Expand Down
2 changes: 1 addition & 1 deletion src/Altinn.Profile.Core/User.ContactPoints/UserContactPoints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ public class UserContactPointsList
/// <summary>
/// A list containing contact points for users
/// </summary>
public List<UserContactPoints> ContactPointList { get; set; } = [];
public List<UserContactPoints> ContactPointsList { get; set; } = [];
}
10 changes: 5 additions & 5 deletions .../Altinn.Profile.Tests/IntegrationTests/API/Controllers/UserContactPointControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public async Task PostLookup_NoNationalIdentityNumbers_EmptyListReturned()
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
string responseContent = await response.Content.ReadAsStringAsync();
var actual = JsonSerializer.Deserialize<UserContactPointsList>(responseContent, _serializerOptions);
Assert.Empty(actual.ContactPointList);
Assert.Empty(actual.ContactPointsList);
}

[Fact]
Expand All @@ -158,8 +158,8 @@ public async Task PostLookup_SingleProfileNotFoundInBridge_RemainingUsersReturne
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
string responseContent = await response.Content.ReadAsStringAsync();
var actual = JsonSerializer.Deserialize<UserContactPointsList>(responseContent, _serializerOptions);
Assert.Single(actual.ContactPointList);
Assert.NotEmpty(actual.ContactPointList[0].Email);
Assert.Single(actual.ContactPointsList);
Assert.NotEmpty(actual.ContactPointsList[0].Email);
}

[Fact]
Expand All @@ -183,8 +183,8 @@ public async Task PostLookup_SingleUser_DetailsReturned()
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
string responseContent = await response.Content.ReadAsStringAsync();
var actual = JsonSerializer.Deserialize<UserContactPointsList>(responseContent, _serializerOptions);
Assert.Single(actual.ContactPointList);
Assert.NotEmpty(actual.ContactPointList[0].Email);
Assert.Single(actual.ContactPointsList);
Assert.NotEmpty(actual.ContactPointsList[0].Email);
}

private async Task<HttpResponseMessage> GetSBlResponseForSsn(string ssn)
Expand Down
Loading