Implementing 404 error when repo is not found (#11449)

Altinn · Nov 1, 2023 · 05a2ab8 · 05a2ab8
1 parent de75623
commit 05a2ab8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/backend/src/Designer/Filters/Git/GitErrorCodes.cs b/backend/src/Designer/Filters/Git/GitErrorCodes.cs
@@ -3,5 +3,6 @@
     public class GitErrorCodes
     {
         public const string NonFastForwardError = "GT_01";
+        public const string RepositoryNotFound = "GT_02";
     }
 }
diff --git a/backend/src/Designer/Filters/Git/GitExceptionFilterAttribute.cs b/backend/src/Designer/Filters/Git/GitExceptionFilterAttribute.cs
@@ -25,6 +25,10 @@ public override void OnException(ExceptionContext context)
                 context.Result = new ObjectResult(ProblemDetailsUtils.GenerateProblemDetails(context.Exception, GitErrorCodes.NonFastForwardError, HttpStatusCode.Conflict)) { StatusCode = (int)HttpStatusCode.Conflict };
             }
 
+            if (context.Exception is LibGit2Sharp.RepositoryNotFoundException)
+            {
+                context.Result = new ObjectResult(ProblemDetailsUtils.GenerateProblemDetails(context.Exception, GitErrorCodes.RepositoryNotFound, HttpStatusCode.NotFound)) { StatusCode = (int)HttpStatusCode.NotFound };
+            }
         }
     }
 }
diff --git a/...d/tests/Designer.Tests/GiteaIntegrationTests/RepositoryControllerGiteaIntegrationTests.cs b/...d/tests/Designer.Tests/GiteaIntegrationTests/RepositoryControllerGiteaIntegrationTests.cs
@@ -156,6 +156,16 @@ public async Task MetadataAndStatus_ShouldBehaveAsExpected(string org)
             deserializedRepoStatusModel.RepositoryStatus.Should().Be(RepositoryStatus.Ok);
         }
 
+        [Theory]
+        [Trait("Category", "GiteaIntegrationTest")]
+        [InlineData(GiteaConstants.TestOrgUsername)]
+        public async Task RepoStatus_ShouldReturn404NotFoundWhenInvalidRepo(string org)
+        {
+            // Call status endpoint
+            using HttpResponseMessage statusResponse = await HttpClient.GetAsync($"designer/api/repos/repo/{org}/123/status");
+            statusResponse.StatusCode.Should().Be(HttpStatusCode.NotFound);
+        }
+
         [Theory]
         [Trait("Category", "GiteaIntegrationTest")]
         [InlineData(GiteaConstants.TestOrgUsername)]