Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Application c# model to app-lib ApplicationMetaData model in backend #11357

Closed
standeren opened this issue Oct 12, 2023 · 1 comment · Fixed by #11435
Closed

Change Application c# model to app-lib ApplicationMetaData model in backend #11357

standeren opened this issue Oct 12, 2023 · 1 comment · Fixed by #11435
Assignees
Labels
backend kind/bug Used when there is a defect / something is not working as it should. solution/studio/code Issues related to DX, coding, debugging and testing locally. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio

Comments

@standeren
Copy link
Contributor

standeren commented Oct 12, 2023

Description

Since we are using the strict typed model from storage (Application) to (de)serialise applicationmetadata.json we are removing custom properties that app-frontend has introduced, such as logo i.e., when we do actions in Studio that demands updates of appmetadata. This involves operations like:

  • Generating the data model since this operation might include changing class name references used in appmetadata
  • Adding/changing/removing attachment components since this updates the data type in appmetadata

The issue of loosing the logo field has been reported by several service owners in slack:

Solution

To avoid this from happening we need to use app-libs extended version of the appmetadata model since this allows all custom fields to be added to it. And when this model is passed to storage (which Studio does during deploy) Storage will ignore the additional properties which is okay since Storage does not need these.

@standeren standeren added solution/studio/designer Issues related to the Altinn Studio Designer solution. solution/studio/code Issues related to DX, coding, debugging and testing locally. backend team/studio labels Oct 12, 2023
@RadhaRajagopalan RadhaRajagopalan added the kind/bug Used when there is a defect / something is not working as it should. label Oct 23, 2023
@standeren standeren self-assigned this Oct 24, 2023
@standeren standeren linked a pull request Oct 24, 2023 that will close this issue
3 tasks
@nkylstad
Copy link
Member

nkylstad commented Nov 2, 2023

Tested OK in dev.altinn.studio.
Added logo manually, and then made changes in the "config" modal to update applicationMetadata.
Logo was still in applicationMetadata file after changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend kind/bug Used when there is a defect / something is not working as it should. solution/studio/code Issues related to DX, coding, debugging and testing locally. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants